]> git.michaelhowe.org Git - packages/o/openafs.git/commit
DAFS: Do not transition to ERROR on trivial errors
authorAndrew Deason <adeason@sinenomine.net>
Wed, 30 Nov 2011 20:36:06 +0000 (14:36 -0600)
committerDerrick Brashear <shadow@dementix.org>
Fri, 16 Dec 2011 11:54:20 +0000 (03:54 -0800)
commit012e9e26b8877b00c32c401d1ee7b980dc494849
treee5e450edf87ff86244d59d97669c69bc3d75c72c
parent8b75b8c44cd46bf88ff66620bb92113a7dd9620f
DAFS: Do not transition to ERROR on trivial errors

attach2 can result in many different errors; some indicate that the
volume is in an inconsistent state, but many others just indicate that
the volume cannot be attached for benign reasons (such as VNOVOL if
the volume doesn't exist, or VOFFLINE if the volume is being used by a
volume utility). Currently, for DAFS, attach2 transitions the relevant
volume to the VOL_STATE_ERROR state for almost all errors encountered,
even the benign ones. Instead, skip the error state transition for
error handling paths that do not reflect a "broken" volume.

Reviewed-on: http://gerrit.openafs.org/6164
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 5fc2365f5dff7f193781093ecb886b4c7391d5a3)

Change-Id: Ia3d732781c98fcda4db7b41cd744db860781594f
Reviewed-on: http://gerrit.openafs.org/6320
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
src/vol/volume.c