]> git.michaelhowe.org Git - packages/o/openafs.git/commit
libadmin: Don't overflow volume name
authorSimon Wilkinson <sxw@your-file-system.com>
Sat, 2 Mar 2013 09:47:53 +0000 (09:47 +0000)
committerStephan Wiesand <stephan.wiesand@desy.de>
Tue, 3 Jun 2014 16:37:55 +0000 (12:37 -0400)
commit06f0b6022342879c5519ff1bd0f272e1bff4538a
tree43048e9080aa32632bedb20e3acc5913aabce0d5
parente6984f84d53115810e7936b8ee240b3a67789e56
libadmin: Don't overflow volume name

The maximum volume name length in the VLDB RPCs is VL_MAXNAMELEN
(65), not 64 as used as a hardcoded value in vsprocs. Switch to
using the defined value, and also use strlcat to check that we
don't overflow this.

Caught by coverity (#985849)

Reviewed-on: http://gerrit.openafs.org/9353
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 79abe9d68ea041a2ea6261c6f7bb1f055a45bf0a)

Change-Id: I0e1dd46be835e74fc43335606bf5ab8341678251
Reviewed-on: http://gerrit.openafs.org/11040
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libadmin/vos/vsprocs.c