]> git.michaelhowe.org Git - packages/o/openafs.git/commit
butc: avoid testing stack garbage; remove dead initializer
authorGarrett Wollman <wollman@csail.mit.edu>
Sun, 7 Aug 2011 03:49:10 +0000 (23:49 -0400)
committerDerrick Brashear <shadow@dementia.org>
Fri, 12 Aug 2011 15:51:58 +0000 (08:51 -0700)
commit09565faea51e624306a2ddcbbb898888db987a12
tree5cf58236822c2cfbb4f993c440ff7639d6595114
parent4aacd49270900f9a882a6265beec4b126df61d8b
butc: avoid testing stack garbage; remove dead initializer

"code" is unconditionally set early in saveDbToTape() so there's
no need to initialize it.  On the other hand, dumpEntry.id is used
before dumpEntry is initialized, so set it to what appears to be
the expected value before any non-local exits could cause it to be
inspected.

Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5166
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit c92f04af6094ce04b1541a1b23b254d3c1421290)

Change-Id: If99aaf327749550623ef5abc3dd077f5291bc899
Reviewed-on: http://gerrit.openafs.org/5226
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/butc/tcudbprocs.c