]> git.michaelhowe.org Git - packages/o/openafs.git/commit
OPENAFS-SA-2018-002 ubik: prevent VOTE_Debug, VOTE_XDebug information leak
authorMark Vitale <mvitale@sinenomine.net>
Tue, 26 Jun 2018 10:01:16 +0000 (06:01 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Sun, 9 Sep 2018 23:35:09 +0000 (18:35 -0500)
commit0ee86cc3f986365df9de21ede5735cc1f40db7e5
tree82aa32c32a95290b5ec515d66c9bb8ced4d9e076
parentc912830e9c82d91bccf85018ef1e6a75edc410c4
OPENAFS-SA-2018-002 ubik: prevent VOTE_Debug, VOTE_XDebug information leak

VOTE_Debug and VOTE_XDebug (udebug) both leave a single field
uninitialized if there is no current transaction.  This leaks the memory
contents of the ubik server over the wire.

struct ubik_debug
- 4 bytes in member writeTrans

In common code to both RPCs, ensure that writeTrans is always
initialized.

[kaduk@mit.edu: switch to memset]

(cherry picked from commit 7a7c1f751cdb06c0d95339c999b2c035c2d2168b)

Change-Id: I2759989bf1a5190f9f03621218224c47094a88b7
src/ubik/vote.c