]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Windows: buf_CleanAsync is not async; rename it
authorJeffrey Altman <jaltman@your-file-system.com>
Fri, 2 Dec 2011 16:14:11 +0000 (11:14 -0500)
committerDerrick Brashear <shadow@dementix.org>
Sun, 26 Feb 2012 06:37:12 +0000 (22:37 -0800)
commit13c676b0ab44f4b369d43652c2e509201e5a4a8f
treecd9f7599bafcd63b899f95b22362bb32e1133cab
parentaf58b42210a6976c512b746dd59dd63ceb0000e8
Windows: buf_CleanAsync is not async; rename it

buf_CleanAsync() calls cm_BufWrite() which stores the dirty
buffers synchronously.  There is nothing asynchronous about
buf_CleanAsync() so rename it to buf_Clean() and buf_CleanAsyncLocked()
to buf_CleanLocked().   Update the comments to remove the references
to the asynchronous processing which doesn't exist.

That is not to say that the call to buf_Clean() in buf_GetNewLocked()
should not be asynchronous; it should.  There is no such functionality
at the moment.  One approach would be to modify buf_IncrSyncer to
trigger on an event set by buf_GetNewLocked() instead of the call
to buf_Clean().  Another approach would be registering a background
store event.  In any case, that is for another patchset.

Reviewed-on: http://gerrit.openafs.org/6172
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit c712403f192bd9932f3ec1dce5fb23461d3d0349)

Change-Id: Ib8d5bb06b0c4ffa3e53d53e24ca9f970b7cb63b0
Reviewed-on: http://gerrit.openafs.org/6811
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/WINNT/afsd/cm_buf.c
src/WINNT/afsd/cm_buf.h