]> git.michaelhowe.org Git - packages/o/openafs.git/commit
linux: dont ignore kmod build errors
authorMichael Meffie <mmeffie@sinenomine.net>
Tue, 3 Jun 2014 03:24:45 +0000 (23:24 -0400)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 26 Jun 2014 09:45:32 +0000 (05:45 -0400)
commit1423a3debec3ec5a67c0ef1c613c02a266529e45
treed81ebbddfcdac4a53bba7061ab1349fcca588d1c
parent9c7f4490af8582c943f115474df645e825ad4cff
linux: dont ignore kmod build errors

Errors from the linux kmod build are not propagated, since make is
run as the first command in a pipeline, and the shell returns the
exit code of the last command in the pipeline.  Run the make command
in a subshell to detect errors, and exit afterwards.  (This method
is more portable than bash specific pipeline processing options.)

Thanks to Mark Vitale for pointing out this build system defect
to me.

Reviewed-on: http://gerrit.openafs.org/11186
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: D Brashear <shadow@your-file-system.com>
(cherry picked from commit 48789d47b613e40734e7b0caac58572a80f8b318)

Change-Id: Idbdfad2a50901041aedaed35b8f01d713a66620d
Reviewed-on: http://gerrit.openafs.org/11205
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Anders Kaseorg <andersk@mit.edu>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libafs/MakefileProto.LINUX.in