]> git.michaelhowe.org Git - packages/o/openafs.git/commit
STABLE14-viced-grow-h_maxSlots-20060123
authorChaskiel M Grundman <cg2v@andrew.cmu.edu>
Mon, 23 Jan 2006 21:30:18 +0000 (21:30 +0000)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Mon, 23 Jan 2006 21:30:18 +0000 (21:30 +0000)
commit21bfb25d40035a7f0fbfc3af45fe0aa8a248e236
tree1af1c43ca61ee21b3de1f094aa29964af1b8fe4d
parent713e30b7d2627b8790290b3c8b308753ef1fd01a
STABLE14-viced-grow-h_maxSlots-20060123

and jhutz@cs.cmu.edu

The size of h_maxSlots as computed based upon the value of
MAX_FILESERVER_THREAD is too small.   It is possible for h_lwpIndex
(in the pthread case) to have produce the same Slot value for multiple
threads.  In that case it is possible for the following to occur:

       X: h_Hold_r(host)
       X: H_UNLOCK
       ...
       E: H_LOCK
       E: Check h_Held_r(host); it is true, so don't hold
       E: H_UNLOCK
       X: H_LOCK
       X: h_Release_r(host)
       X: h_TossStuff_r(host)  [called by h_Release_r]
       X: H_UNLOCK
       E: CheckHost(host)

The end result would be a crash due to a reference to a null field
in the host processed by CheckHost.

This patch is a bit of a hack in that it solves the problem by increasing
the number of slots for threads and does not determine the correct number
of threads the process should be allowed to produce.

(cherry picked from commit 4a5dda84178842e3eaa61d03fecc96149333dd13)
src/viced/host.h