]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Fix static expressions in conditionals
authorPat Riehecky <riehecky@fnal.gov>
Fri, 1 Jun 2018 21:33:37 +0000 (16:33 -0500)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 25 Jul 2019 11:17:15 +0000 (07:17 -0400)
commit22c9d9f8916cef5eacc9c930fc25c34c24de17e4
treeacb373f03b871ab318c1dfb4ae328b70b28a44e7
parent277d69d4358f94bf176268a5a98da39bf5277589
Fix static expressions in conditionals

The conditions in these if statements are always true (or always false).
Remove the check in cmdebug.c, as it is unnecessary, and fix the check
in vlclient.c to actually check for a valid voltype. (via cppcheck)

Reviewed-on: https://gerrit.openafs.org/13158
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 5cd5cd9fa8754a5af346fa6a392363b046316c75)

Change-Id: Ie3a2d6bfc99d1b5adf0524afc29dac30b655d04d
Reviewed-on: https://gerrit.openafs.org/13638
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/venus/cmdebug.c
src/vlserver/vlclient.c