]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Don't double free call structure
authorSimon Wilkinson <sxw@inf.ed.ac.uk>
Sat, 16 Jan 2010 15:52:58 +0000 (15:52 +0000)
committerDerrick Brashear <shadow|account-1000005@unknown>
Sat, 16 Jan 2010 16:07:43 +0000 (08:07 -0800)
commit26ffbd3f1c07420796c772e821786cfa4bcc0bc5
treed9c53a8f153f9e782f71b8dd3095c4c6d25321b4
parent25b99a9c267b722642d4008929e074f76f9efe49
Don't double free call structure

If the rx_Read() of the number of bytes in the FetchData64 response
fails, then it sets code, and disposes of the call structure. However,
the length safety check that was added in
c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 executes regardless of whether
code is set, and the call has already been freed. So we end up calling
rx_Error with a NULL call structure, and panic.

(pulled up from 806423be3c55f3de91c2b836d2088eeb0f4e4665)

Change-Id: Ia1ee4ab9c794db9337e4eb7b5b5980c8a57cef0b
Reviewed-on: http://gerrit.openafs.org/1113
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/afs/afs_dcache.c