]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Add array bounds checking in h_Enumerate
authorDan Hyde <drh@umich.edu>
Thu, 29 Oct 2009 16:07:47 +0000 (12:07 -0400)
committerDerrick Brashear <shadow|account-1000005@unknown>
Fri, 20 Nov 2009 20:49:01 +0000 (12:49 -0800)
commit2d6c0390f8ca702c05cb0c13e0994751a60285f9
treeb5bd6d90eb160b32f175bb559a65f786ffbfed77
parent2f87c43ecec4f9efd5a7f26ee0ff10b9e2333585
Add array bounds checking in h_Enumerate

When hostList is not properly NULL-terminated, the current code does
not protect from buffer overflow.  The following patch prevents buffer
overflow, prints a message, and asserts.

On our Linux hosts, we never reached the original assert, as there is
a problem handling the segfault the buffer overflow causes.

FIXES 125506

Reviewed-on: http://gerrit.openafs.org/757
Reviewed-by: Dan Hyde <drh@umich.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 93d48b1735b88b3051357307bdbebf5da9872d69)

Change-Id: Idb920d2bd309b40ae9bebc6972e614ddf9ba8dcc
Reviewed-on: http://gerrit.openafs.org/862
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/viced/host.c