]> git.michaelhowe.org Git - packages/o/openafs.git/commit
volser: range check acl header fields during dumps and restores
authorMichael Meffie <mmeffie@sinenomine.net>
Fri, 30 Jan 2015 17:12:03 +0000 (12:12 -0500)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 31 Mar 2016 08:47:00 +0000 (04:47 -0400)
commit30da3d32533ce225d8d89099b0c3355f01a946a9
treec8790f7d98b60a971fbccc13ef4c617dc1cbee52
parentc402e60e2b2af0f4f1cdd7129dcceb678e2b3f09
volser: range check acl header fields during dumps and restores

Perform range checks on the acl header fields when reading an
acl from a dump stream and when writing an acl to a dump
stream.

Before this change, a bogus value in the total, positive, or
negative acl fields from a dump stream could cause an out of
bounds access of the acl entries table, crashing the volume
server.

Reviewed-on: http://gerrit.openafs.org/11702
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 0bf9fba458b39035a09f45c1b63f1e65672d4c00)

Change-Id: Icebeb1d62900a7978f02177627a30e41de49a182
Reviewed-on: https://gerrit.openafs.org/12127
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libacl/netprocs.c
src/volser/dumpstuff.c
src/volser/vol-dump.c