]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Include com_err.h in dumpstuff.c
authorAndrew Deason <adeason@sinenomine.net>
Fri, 6 Aug 2010 18:01:51 +0000 (13:01 -0500)
committerRuss Allbery <rra@debian.org>
Wed, 11 Aug 2010 04:46:56 +0000 (21:46 -0700)
commit317a725a8081feeda71a4bad30daff85836cde60
tree7f174eac2d24772db0b0ad66e20f574fa81d7212
parentca593bb83aaffd96e1965f6f3684c3136266b34f
Include com_err.h in dumpstuff.c

src/volser/dumpstuff.c uses afs_error_message in its error reporting,
but it does not include com_err.h, so it does not get the prototype
for afs_error_message. The default return type for unprototyped
functions is 'int', so the return value of afs_error_message can get
truncated on platforms where sizeof(char*) > sizeof(int), causing a
segfault whenever the result of afs_error_message is logged.

This is a 1.4-only change. This was fixed in the 1.5 branch in the
midst of the larger warning cleanup effort.

Change-Id: Id3bcde20609130d8e4e393c6c8aae75682bcd966
Reviewed-on: http://gerrit.openafs.org/2526
Tested-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ebb6accf18cf3eeb6a99025ccf5228f979463d0e)
src/volser/dumpstuff.c