]> git.michaelhowe.org Git - packages/o/openafs.git/commit
kauth: Fix overflow when writing ticket file
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 26 Feb 2013 22:40:04 +0000 (22:40 +0000)
committerStephan Wiesand <stephan.wiesand@desy.de>
Tue, 3 Jun 2014 16:20:26 +0000 (12:20 -0400)
commit3afc0fdfcfef07d11046a34b8c74ad0f7b1bb9ad
treea86b56fc7a8e6f59b6ec25bf7e5e8fb74f01c691
parent7822702cf80de1902de5fe8fe0e7128690622a6f
kauth: Fix overflow when writing ticket file

krb_write_ticket_file uses a fixed length buffer to store the name
of the ticket file, but copies into this from an environment variable.

Remove the fixed length buffer, and use a mixture of the variable
itself, and dynamically allocated strings.

Caught by coverity (#985909)

Reviewed-on: http://gerrit.openafs.org/9294
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit a332ce9d0e87fab55f3d286690026fe075f624dd)

Change-Id: Idcf442323b13cc4daa893917ede6492616ba1aeb
Reviewed-on: http://gerrit.openafs.org/11021
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/kauth/krb_tf.c