]> git.michaelhowe.org Git - packages/o/openafs.git/commit
vos: don't free stack garbage on error
authorGarrett Wollman <wollman@csail.mit.edu>
Sun, 7 Aug 2011 03:15:14 +0000 (23:15 -0400)
committerDerrick Brashear <shadow@dementia.org>
Fri, 12 Aug 2011 15:52:12 +0000 (08:52 -0700)
commit3fd135d48b76b2e54329b75e53a67cac1abb29d4
tree98889eea0a79a72f718a2ba6e3427741435cb36a
parent09565faea51e624306a2ddcbbb898888db987a12
vos: don't free stack garbage on error

If wantExtendedInfo is true, then pntr is used uninitialized.
In the other case, UV_ListVolumes will have set it to NULL
before doing anything (even if it returns an error), so this
free() is dead anyway.

Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5164
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 619b420903c99e48618db0d2f12085111573f279)

Change-Id: Icd76d3ac160ccb04b05445552a9e6d04f053efbb
Reviewed-on: http://gerrit.openafs.org/5227
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/volser/vos.c