]> git.michaelhowe.org Git - packages/o/openafs.git/commit
OPENAFS-SA-2018-002 butc: prevent TC_DumpStatus, TC_ScanStatus information leaks
authorMark Vitale <mvitale@sinenomine.net>
Tue, 26 Jun 2018 09:12:32 +0000 (05:12 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Sun, 9 Sep 2018 23:35:06 +0000 (18:35 -0500)
commit43b3efd4f8cd3227b2b24ff673adeb834f6a3f0b
treef88b4ec7f48a8a7fd7c1d1e3082e7beab77009bd
parentb7e53b9e9706d63215a1804ed9eca30d69461f03
OPENAFS-SA-2018-002 butc: prevent TC_DumpStatus, TC_ScanStatus information leaks

TC_ScanStatus (backup status) and TC_GetStatus (internal backup status
watcher) do not initialize their output buffers.  They leak memory
contents over the wire:

struct tciStatusS
- up to 64 bytes in member taskName (TC_MAXNAMELEN 64)
- up to 64 bytes in member volumeName  "

Initialize the buffers.

[kaduk@mit.edu: move initialization to top of server routines]

(cherry picked from commit be0142707ca54f3de99c4886530e7ac9f48dd61c)

Change-Id: I7a97ad1dbab004938085b401929d4925d80ff3b2
src/butc/tcstatus.c