]> git.michaelhowe.org Git - packages/o/openafs.git/commit
libadmin: Clear structures according to their size.
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 30 Mar 2012 18:16:50 +0000 (19:16 +0100)
committerStephan Wiesand <stephan.wiesand@desy.de>
Tue, 24 Sep 2013 18:27:23 +0000 (11:27 -0700)
commit47fb5837820e0dcf46c0c19a15b81848e75be3aa
tree51547ff8e224ff251317ecbe2d89e734c8017e3e
parentb4de9dc5b030c04cfee5514ef8ca4f4497713699
libadmin: Clear structures according to their size.

memset(a, 0, sizeof(a)) is rarely correct, unless a is an error. Use the
size of the destination structure, rather than the size of a pointer to it
when deciding how much memory to clear.

Caught by clang's new error messages

Reviewed-on: http://gerrit.openafs.org/7076
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 34afb3e6b903fc1659b1c869fa2fb4226038e076)

Change-Id: I06912a70af9f3cd54f4a5368e996a7308e687c20
Reviewed-on: http://gerrit.openafs.org/10243
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libadmin/vos/afs_vosAdmin.c