]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Don't trust # of entries from ListAttributes
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 26 Dec 2010 14:54:43 +0000 (14:54 +0000)
committerDerrick Brashear <shadow@dementia.org>
Sat, 5 Mar 2011 13:53:05 +0000 (05:53 -0800)
commit511fc5d4b50bce273c16acef7b551b8517a6bf46
tree542b89e992dcf1372eb02ac4642ea611847a6c23
parent70938028cd1267aa604d8b983473403eec702a20
Don't trust # of entries from ListAttributes

ListAttributes returns the number of entries in its array as an RPC
argument. But, we can't trust this, as it could be manipulated and
end up pointing past the end of the returned array (which is counted,
so the entries argument is actually pointless).

Add bounds checking to the functions which use this value to prevent
this problem.

(cherry picked from commit 8992210f27671673a89a541776aa105238ad14cf)
Reviewed-on: http://gerrit.openafs.org/3597
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Change-Id: I318f2f956a48f10e91590ad9f28fab868d8ceb60
Reviewed-on: http://gerrit.openafs.org/4134
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/bucoord/commands.c
src/libadmin/vos/vosutils.c
src/volser/vsutils.c