]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Windows: not safe to dereference before locking
authorJeffrey Altman <jaltman@your-file-system.com>
Wed, 13 Jul 2011 12:15:04 +0000 (08:15 -0400)
committerDerrick Brashear <shadow@dementia.org>
Thu, 14 Jul 2011 05:43:47 +0000 (22:43 -0700)
commit5452fa62c98b08b5ec3a85d2b7c08585294d4906
tree6dee5ee90cac2a0137a32478046dcd2c8e82787f
parent00d8cbfe5563b5363ceaa4c65f52d3104f596004
Windows: not safe to dereference before locking

Throughout cm_server.c, input parameters to functions that
are protected by cm_serverLock are dereferenced by assignment
during variable initialization prior to the cm_serverLock being
obtained.  As a result there is a race which can result in
either list corruption or dereferencing freed memory.

Reviewed-on: http://gerrit.openafs.org/4985
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 130155ff3c48f2da2433b359588346b4438d24a2)

Change-Id: I02e83faa889bb55b025253bbd1c51a389434eee4
Reviewed-on: http://gerrit.openafs.org/5014
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/WINNT/afsd/cm_server.c