]> git.michaelhowe.org Git - packages/o/openafs.git/commit
rxdebug: NUL-terminate version before printing
authorAndrew Deason <adeason@dson.org>
Thu, 15 Feb 2018 22:41:33 +0000 (16:41 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Fri, 23 Feb 2018 04:18:14 +0000 (23:18 -0500)
commit55fbc8ee055958b309011eeb62d7166ff0415905
tree7e38d624971d6baed50990782d1699d3f7a37f98
parent3d58c397c6935afd64e3a41017baf627106a3003
rxdebug: NUL-terminate version before printing

Currently, 'rxdebug -version' never initializes the buffer we read the
version string into. Usually this is not noticeable, since all OpenAFS
binaries tend to pad the Rx version response packet with NULs, so we
get back several NULs to terminate the string. However, this is not
guaranteed, and if we do not get back a NUL-terminated string, we can
easily read beyond the end of the buffer.

To avoid this, initialize the 'version' buffer with NULs before we do
anything, and set the last byte to NUL, in case we exactly filled the
buffer.

Reviewed-on: https://gerrit.openafs.org/12908
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: Andrew Deason <adeason@sinenomine.net>
(cherry picked from commit a66629eac4dda4eea37b4f06e0850641cb2a7387)

Change-Id: I850ce16840ee264dce506e8b3c887004bca11e20
Reviewed-on: https://gerrit.openafs.org/12912
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/rxdebug/rxdebug.c