]> git.michaelhowe.org Git - packages/o/openafs.git/commit
DARWIN: Make crfree() an inline function
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 30 Mar 2012 18:09:36 +0000 (19:09 +0100)
committerStephan Wiesand <stephan.wiesand@desy.de>
Fri, 20 Dec 2013 15:07:56 +0000 (07:07 -0800)
commit59269b39b2dcc6ad9157c674b0104beecba46206
treefcd8a8906bedfc7afffbe625d7842c68cd25478c
parent5f45d5b8ebee3a6b2fc0be5e2d6a6c1036d88408
DARWIN: Make crfree() an inline function

On Darwin 100, we have
   #define crfree(X) kauth_cred_unref(&X)
which expands in one place to
   kauth_cred_unref(&(afs_ucred_t *)avc->linkData)

clang warns about this in -Werror mode, because arguments to the
address-of operator must be lvalues.

To fix this make crfree an inline function, which will then let us do
the indirection required.

Reviewed-on: http://gerrit.openafs.org/7073
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 1d8937b860509fcaabb041bc14faf7aa3023f3c9)

Reviewed-on: http://gerrit.openafs.org/10548
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
(cherry picked from commit 931d1a8bea393ba3df69b163cb4d05c35f3c948e)

Change-Id: Iba1def8ae4004e918185109767bd8a0f0a263813
Reviewed-on: http://gerrit.openafs.org/10607
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/DARWIN/osi_machdep.h