]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Avoid calling krb5_free_context(NULL)
authorAndrew Deason <adeason@sinenomine.net>
Fri, 1 Feb 2019 22:31:50 +0000 (16:31 -0600)
committerStephan Wiesand <stephan.wiesand@desy.de>
Sun, 26 Jan 2020 12:52:09 +0000 (07:52 -0500)
commit64d0352df1406d9601d6d772555c4c39efc05d7e
treee21bbba298ae3aa6b4790233693f0bf6c7e96e74
parentc3869ac05b8eb816b1b8844d628f796a06d15914
Avoid calling krb5_free_context(NULL)

Several places in the code currently call krb5_free_context(ctx) in a
cleanup code path, where 'ctx' may or may not be NULL. This is not
guaranteed to be okay, so check for NULL to make sure we don't cause
issues in these code paths.

While we are here cleaning up krb5_free_context() calls, also fix a
few call sites in afscp_util.c that were not calling krb5_free_context
in all error paths.

Reviewed-on: https://gerrit.openafs.org/13461
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 26b1dc036719a588a5cadecb14053bd4079c1f48)

Change-Id: I3b0d22f51f4fe85897116b7f96d096570258eed2
Reviewed-on: https://gerrit.openafs.org/13902
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/aklog/aklog.c
src/libafscp/afscp_util.c
src/rxkad/ticket5.c