]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Avoid libtool 'nm' errors
authorAndrew Deason <adeason@sinenomine.net>
Wed, 7 Mar 2018 19:28:34 +0000 (13:28 -0600)
committerBenjamin Kaduk <kaduk@mit.edu>
Sun, 3 Jun 2018 14:09:49 +0000 (10:09 -0400)
commit690b0f0bd238695a2ccde3842198812fb9b89f5d
treea310c3feba398192426847d37f859c8a244f4c46
parentad86112bbde0979efd4e99f23ca629f93fa258b1
Avoid libtool 'nm' errors

Starting around Solaris 11.3, '/usr/bin/nm -p' starts reporting some
symbols with the 'C' code. libtool cannot handle this (libtool bug
 #22373), which causes global_symbol_pipe in the generated libtool
script to be empty. This causes a rather confusing error when we go to
actually use libtool to link something ("syntax error near unexpected
token '|'"; see libtool bug #20947), and prevents the build from
continuing.

Address this in two ways:

For all Solaris 11 builds, default to /usr/sfw/bin/gnm over
/usr/bin/nm. This avoids any interop issues with libtool and nm, since
libtool of course works very well with GNU tooling.

In addition, try to catch any nm-related errors with libtool at
configure time, to provide a more helpful error message.

To implement these changes, create a wrapper around LT_INIT, called
AFS_LT_INIT.

Reviewed-on: https://gerrit.openafs.org/12945
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 3e9ea6107973ccc4fa3d405f5b5d76666bfd624f)

Change-Id: I4a5a358857ec5bfbc31cd99fcca59f3390ad4d16
Reviewed-on: https://gerrit.openafs.org/13066
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
configure.ac
src/cf/afs-libtool.m4 [new file with mode: 0644]