]> git.michaelhowe.org Git - packages/o/openafs.git/commit
STABLE14-check-host-optimize-20060123
authorJeffrey Altman <jaltman@secure-endpoints.com>
Mon, 23 Jan 2006 21:28:43 +0000 (21:28 +0000)
committerJeffrey Altman <jaltman@secure-endpoints.com>
Mon, 23 Jan 2006 21:28:43 +0000 (21:28 +0000)
commit713e30b7d2627b8790290b3c8b308753ef1fd01a
tree4fbc4e2298c54eecba5e2f74c3c0671c3491e84e
parent6867198aa1873f9a050fde52a0b3a77068a2c549
STABLE14-check-host-optimize-20060123

There should never be a case where h_Enumerate calls CheckHost with a
host whose callback_rxcon that is NULL.  However, due to a bug it ended up
being the case that it happened.  An examination of the CheckHost code
showed that the check for the HOSTDELETED flag should take place before
a reference to callback_rxcon is obtained.  If HOSTDELETED were set, the
code would simply release the reference immediately.  However, the process
of obtaining and releasing the reference required dropping and obtaining
locks that would be a performance hit.

(cherry picked from commit ff40c87da3ce4c6a7a58c08eaa223e8760dc8f73)
src/viced/host.c