]> git.michaelhowe.org Git - packages/o/openafs.git/commit
DAFS: do not save or restore host state if CPS in progress
authorMark Vitale <mvitale@sinenomine.net>
Tue, 21 Feb 2017 01:16:47 +0000 (20:16 -0500)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 25 May 2017 17:46:41 +0000 (13:46 -0400)
commit72a48c34e79b6bf0ea251cf46122c973d1bf6555
treef397c0c4115a62a773ddf78cd2bfa65b9e791b25
parentfb7eceb7606c91d9cd8b3ce196a81c110c58a3be
DAFS: do not save or restore host state if CPS in progress

If a fileserver is shutdown while one or more PR_GetHostCPS calls
are in progress, this state is saved in the fsstate.dat file as
hostFlags HCPS_WAITING, HCPS_INPROGRESS.  Other hosts that are
merely waiting will have HCPS_WAITING recorded.

However, it makes no sense to restore host structs in this state,
because the GetCPS calls will no longer be in progress.  Once these
hosts become active, they will block server threads and quickly cause
all server threads to be exhausted as other CPS requests are blocked
behind them.

Instead, exclude these states from both save and restore.

Reviewed-on: https://gerrit.openafs.org/12561
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 38a3f51fb8b3910ecdd7cacb06f35ec681990aea)

Change-Id: I0e02543fd2e547fcc9f95db0973f09e5951a1da1
Reviewed-on: https://gerrit.openafs.org/12568
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/viced/host.c