]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Unix CM: Don't overflow ICL logs array
authorSimon Wilkinson <sxw@your-file-system.com>
Thu, 28 Feb 2013 13:45:00 +0000 (13:45 +0000)
committerStephan Wiesand <stephan.wiesand@desy.de>
Fri, 22 Mar 2013 13:03:44 +0000 (06:03 -0700)
commit81aee1540534350bc33826bf207c7ee1df147f63
tree6636a43329c8f664d7f335bd0cdb954ec0cf1e32
parentd8c76c472a4d85c8d30de6ea4f02e4b3aeb07945
Unix CM: Don't overflow ICL logs array

When checking whether a user supplied index into the ICL logs array
is out of bounds, we need to check whether it is greater or equal
to the maxmimum number of elements. Otherwise we can access one
more than the number of elements in the array.

Caught by coverity (#985567)

Reviewed-on: http://gerrit.openafs.org/9311
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit ff8bae8938532d95f792258d2c520705e095e7af)

Change-Id: I5dba0d22d4589cb7d1f0a4fe57623646d300ab61
Reviewed-on: http://gerrit.openafs.org/9378
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/afs_icl.c