]> git.michaelhowe.org Git - packages/o/openafs.git/commit
rx: RX_INVALID_OPERATION abort unknown service only
authorJeffrey Altman <jaltman@your-file-system.com>
Sun, 25 Nov 2012 00:47:01 +0000 (19:47 -0500)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 6 Dec 2012 18:16:29 +0000 (10:16 -0800)
commit836c696dc38adc0ec03fff638704ea00d5ffd0da
treeee38c296b71437e76702dbda2188443b80dadbfa
parent14657f6bacb3607dc20d1846202744d2f6e83daf
rx: RX_INVALID_OPERATION abort unknown service only

Patchset 1fbe83f9aacfc36a9c426ba1fd18ad7c72869dc1 introduced the
sending of RX_INVALID_OPERATION aborts for connection attempts
requesting a service not offered by the rx peer.  By sending aborts
for all failures of rxi_FindConnection() the set of incoming packets
that are responded to is broader than simply those with non-matching
serviceIds.  This patchset restricts the transmission of
RX_INVALID_OPERATION aborts only to the explicit case in which
rxi_FindConnection() attempted to find a service and either failed
to find a match or couldn't apply the requested security class/level
to that service.

Reviewed-on: http://gerrit.openafs.org/8512
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 81212b18b3411b538c4a1bb94732948902005beb)

Change-Id: Ic732c013d6f77df991e97de7f1c5af88a194e81c
Reviewed-on: http://gerrit.openafs.org/8608
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/rx/rx.c
src/rx/rx_prototypes.h