]> git.michaelhowe.org Git - packages/o/openafs.git/commit
RedHat: Fail openafs-client 'stop' on rmmod error
authorAndrew Deason <adeason@sinenomine.net>
Wed, 8 Feb 2012 22:03:29 +0000 (16:03 -0600)
committerDerrick Brashear <shadow@dementix.org>
Thu, 23 Feb 2012 01:56:24 +0000 (17:56 -0800)
commit887cffa07e6097365d6ce425bbf4297b8f2d782d
treea37c56472872d4963cf64f01e37495d32e19d496
parent145ca8e5a724bfc2f30751f866c9dfe60e7fff7f
RedHat: Fail openafs-client 'stop' on rmmod error

Currently, the openafs-client RPM init script ignores any error
reported by rmmod. If 'umount /afs' succeeds but rmmod does not, the
client may panic the machine if the client is started again (from e.g.
running the 'restart' init script method), since afsd will try to
initialize AFS with a libafs that has been shut down.

So, do not ignore errors from 'rmmod', and instead fail the 'stop'
method from the init script if we get an error.

Reviewed-on: http://gerrit.openafs.org/6709
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 12e2a3abe7ca640a7cef2630039c06964f779f17)

Change-Id: I31256abac839c9011754445efa09960f061fdbb0
Reviewed-on: http://gerrit.openafs.org/6757
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/packaging/RedHat/openafs-client.init