]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Windows: remove faulty assumptions about device names in vol-salvage
authorRod Widdowson <rdw@steadingsoftware.com>
Sun, 23 Jan 2011 12:04:59 +0000 (12:04 +0000)
committerDerrick Brashear <shadow@dementia.org>
Tue, 8 Feb 2011 14:51:50 +0000 (06:51 -0800)
commit9110aac6930a84bc9c61c988743e3b1a447d54df
treeac42af7ae9e97195e796899be766b8890f858c6f
parentfb90ef8b3c658644f5153c373fd2d3ad47815625
Windows: remove faulty assumptions about device names in vol-salvage

The implementation has an assumption that all disk volumes have an
object name of \Device\HarddiskXXX (where XXX is a number).  This is
wrong since the name is purely a convention and since about WXP they
have been called \Device\HarddiskVolumeXXX.

Either way it is spurious to assume the format and then try to compare
the XXX.  This change just compares the strings.  This is done in a
case insenstive manner which is the safer option.  It is quite
feasible, but very unlikely that someone will uses 'case sensitively
different' object names.

Reviewed-on: http://gerrit.openafs.org/3745
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit ffb0cdcc91d86f6e7b62561aebe6dcb722c3d768)

Change-Id: I3f69c2a8f76d073afcfe626eec45be9942bf4042
Reviewed-on: http://gerrit.openafs.org/3859
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/vol/vol-salvage.c