]> git.michaelhowe.org Git - packages/o/openafs.git/commit
vol-salvage: Only delete bad vnodes during !check
authorAndrew Deason <adeason@sinenomine.net>
Tue, 25 Jan 2011 16:46:38 +0000 (10:46 -0600)
committerDerrick Brashear <shadow@dementia.org>
Tue, 8 Feb 2011 14:53:55 +0000 (06:53 -0800)
commita9b922a282cb25cf8de384ba7f1a751ee5e88f24
treea7182f79a1af88abd71ba6bd349d7be16afb8704
parent2e2da579524244cc4ec2e18f3608700c9c3b3072
vol-salvage: Only delete bad vnodes during !check

In SalvageIndex, if check is true, we're only supposed to check for
consistency and not actually change anything (this is enforced by an
assert later on). The check for vnode magic consistency breaks this
assumption, and just always fixes the vnode.

Change this so we just error out if check is set, and the vnode magic
is wrong.

Reviewed-on: http://gerrit.openafs.org/3756
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 5817a13b84496c087b350be50c17a8b0f9aac9d5)

Change-Id: I1b12c56d680111ba71b611ab9bbb6159a35dd14e
Reviewed-on: http://gerrit.openafs.org/3866
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/vol/vol-salvage.c