]> git.michaelhowe.org Git - packages/o/openafs.git/commit
The interminable rework of afs_random()
authorBenjamin Kaduk <kaduk@mit.edu>
Fri, 9 Aug 2019 14:59:44 +0000 (07:59 -0700)
committerStephan Wiesand <stephan.wiesand@desy.de>
Sun, 26 Jan 2020 17:57:24 +0000 (12:57 -0500)
commitb3ce4c493a6920b160e7ecd251fcc694891d3446
treeac9aa2e1237a3661f957e60147d4cdec42839d37
parentf5f44ca2efa3534e84a5311fec7a637ec7bf5d9b
The interminable rework of afs_random()

Commit f0a3d477d6109697645cfdcc17617b502349d91b restructured the
operation on tv_usec to avoid using undefined behavior, but in
the process introduced a behavior change.  Historically (at least as
far back as AFS-3.3), we masked off the low nybble (four bits) of
tv_usec before adding the low byte (eight bits) of the rxi_getaddr()
output.  Why there was a desire to combine two sources of input for
the overlapping four bits remains unclear, but restore the historical
behavior for now, as the intent of commit
f0a3d477d6109697645cfdcc17617b502349d91b was to not introduce any
behavior changes.

Reviewed-on: https://gerrit.openafs.org/13759
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 1c4e94da2a8fce9d79006ad6d6673d3d7de117d3)

Change-Id: Iec10673e5ec73c1e0edcc231690cb6133fce8691
Reviewed-on: https://gerrit.openafs.org/13879
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/afs_server.c