]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Avoid using released hosts
authorAndrew Deason <adeason@sinenomine.net>
Wed, 28 Oct 2009 16:06:47 +0000 (11:06 -0500)
committerRuss Allbery <rra@debian.org>
Wed, 4 Nov 2009 01:29:50 +0000 (17:29 -0800)
commitb4f047ffd28cb76a4afbca65cd7b8316d49a3d59
treef507f2b468c27ac1c6c48bf5f7886ad12f2d3be2
parent14d361253ec7a7b1756c193c091acc119d6fcb43
Avoid using released hosts

Since h_Release_r has the possibility of freeing a host, we should not
be using a host after it has been released. A few places can still use a
released host, potentially causing heap corruption, double frees, and
generally weird behavior.

So either move calls of h_Release_r until after we finish using a host,
or make sure to set the pointer to NULL after it has been released.

Reviewed-on: http://gerrit.openafs.org/747
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Dan Hyde <drh@umich.edu>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 416e2f11c35f5d55f91090b30b4db1a9bf6d6e07)

Change-Id: I91bd09c3e6d87476de8c66c2eb710c0fd424cadd
Reviewed-on: http://gerrit.openafs.org/762
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/viced/afsfileprocs.c
src/viced/callback.c
src/viced/host.c