]> git.michaelhowe.org Git - packages/o/openafs.git/commit
DAFS: Avoid logging harmless LEAVE_OFF failures
authorAndrew Deason <adeason@sinenomine.net>
Wed, 8 Dec 2010 20:57:13 +0000 (14:57 -0600)
committerDerrick Brashear <shadow@dementia.org>
Tue, 1 Feb 2011 04:13:06 +0000 (20:13 -0800)
commitb5f0df472f9a39492de2cfb3855362a89ad4603b
tree7f63fa1a2e0437622fc4a362f9a665e59310492c
parent5d400f224c843d854eebbe7b76bd83a570c5c6ff
DAFS: Avoid logging harmless LEAVE_OFF failures

The DAFS volserver can create temporary destroyMe volumes, which it
then tells the fileserver to keep offline with an FSYNC_VOL_LEAVE_OFF
message. When the fileserver doesn't know that the volume exists,
currently it responds with SYNC_DENIED, which causes the volserver to
log the error with a "negative response on circuit FSSYNC" message.

These are harmless, though, since leaving a volume offline that the
fileserver does not know about is a no-op. So return the SYNC_FAILED
code instead, which does not get logged, and is more consistent with
some other FSYNC handlers like FSYNC_VOL_DONE.

Reviewed-on: http://gerrit.openafs.org/3494
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit f88c91f7778b9a8bf920dce08ccab76ac0b1b433)

Change-Id: Ib3956cf1035b8d9dbcc985877304837a52f9d760
Reviewed-on: http://gerrit.openafs.org/3799
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/vol/fssync-server.c