]> git.michaelhowe.org Git - packages/o/openafs.git/commit
rxgen: Don't overflow PackageIndex
authorSimon Wilkinson <sxw@your-file-system.com>
Fri, 1 Mar 2013 11:35:05 +0000 (11:35 +0000)
committerStephan Wiesand <stephan.wiesand@desy.de>
Tue, 3 Jun 2014 16:31:34 +0000 (12:31 -0400)
commitb76b80bb08173edb5d2423c4edcd951b6630c679
treefda2bac5d23287cc69cf83bfbaf5faeaa9f5b6d6
parent2e644c3d860b5576be0cdf69b09b554fc4af1542
rxgen: Don't overflow PackageIndex

PackageIndex++ returns the pre-index value of PackageIndex, so the
error statement isn't run when PackageIndex == MAX_PACKAGES. This
means we go on to overflow all of the arrays that are MAX_PACKAGES
in size.

Caught by coverity (#985583, #985584, #985585, #985586,
                    #985587, #985588, #985589)

Reviewed-on: http://gerrit.openafs.org/9325
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit a1d8109c8fa8c10e3ce5ed67cda03b3b557608ff)

Change-Id: I5278bff5fe6be1bf127b240f7752c69385a9da24
Reviewed-on: http://gerrit.openafs.org/11033
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/rxgen/rpc_parse.c