]> git.michaelhowe.org Git - packages/o/openafs.git/commit
OPENAFS-SA-2018-002 butc: prevent TC_ReadLabel information leak
authorMark Vitale <mvitale@sinenomine.net>
Tue, 26 Jun 2018 09:00:25 +0000 (05:00 -0400)
committerBenjamin Kaduk <kaduk@mit.edu>
Sun, 9 Sep 2018 23:35:04 +0000 (18:35 -0500)
commitb7e53b9e9706d63215a1804ed9eca30d69461f03
tree24b1222d240fdc7b262a6e155a3951efdd93473c
parent6f26a945adeca87b669282eed0eaca3dca0a1423
OPENAFS-SA-2018-002 butc: prevent TC_ReadLabel information leak

TC_ReadLabel (backup readlabel) does not initialize its output buffer
completely.  It leaks butc memory contents over the wire:

struct tc_tapeLabel
- up to 32 bytes from member afsname (TC_MAXTAPELEN 32)
- up to 32 bytes from member pname (TC_MAXTAPELEN 32)

Initialize the buffer.

[kaduk@mit.edu: move initialization to the RPC stub]

(cherry picked from commit 52f4d63148323e7d605f9194ff8c1549756e654b)

Change-Id: Ia5d9dd649bdbd45c8b201f344bf55080a55e3392
src/butc/tcprocs.c