]> git.michaelhowe.org Git - packages/o/openafs.git/commit
vlserver: do not perform ChangeAddr on mh entries, except for removal
authorMichael Meffie <mmeffie@sinenomine.net>
Tue, 16 Dec 2014 21:13:01 +0000 (16:13 -0500)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 14 Apr 2016 10:56:05 +0000 (06:56 -0400)
commitce8c728f4bbc34286714ce99898edb5a928c2a65
tree4a6e150b9c2e165beba0ef89537710ce330836ca
parent994531efe704a59a0b7c5fa5cfad6c41397252d4
vlserver: do not perform ChangeAddr on mh entries, except for removal

Fix a long standing bug in the ChangeAddr RPC which damages the vldb,

When vos changeaddr is run with -oldaddr and -newaddr, and the -oldaddr
is present in an multi-homed entry, instead of changing the address in
the mh entry, the server slot is "downgraded" to a single homed entry
and the mh entry is orphaned in the vldb.

Instead, if the -oldaddr is in a multi-home entry, refuse to change the
address with a VL entry not found error and log the event.

Multi-homed addresses can be changed manually using the vos setaddrs
command which calls the RegisterAddrs() RPC.

Reviewed-on: http://gerrit.openafs.org/11639
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Daria Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit 1cc77cd43732cca1c617db329a71693903d2b699)

Change-Id: I14a77317d582dd1cb8490e643b8fdfc86f4942c0
Reviewed-on: https://gerrit.openafs.org/12089
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/vlserver/vlprocs.c