]> git.michaelhowe.org Git - packages/o/openafs.git/commit
viced: Avoid ref leak on origin callback break
authorAndrew Deason <adeason@sinenomine.net>
Wed, 27 Apr 2011 19:23:43 +0000 (14:23 -0500)
committerDerrick Brashear <shadow@dementia.org>
Tue, 3 May 2011 02:19:03 +0000 (19:19 -0700)
commitcfd5d1461e6fa28ab277575991d5f8eda3e46ce0
tree4122a52853bc74099139f6a6b26a033eb93e7281
parentb1ce3765d3427caa96c9cb33ec772212531b5031
viced: Avoid ref leak on origin callback break

When breaking a callback, sometimes we send a callback to the host
that performed the callback-inducing operation. When we do this,
currently BreakCallBack gives the origin host structure to
MultiBreakCallBack_r, which avoids releasing that host after the
callback is broken.

However, BreakCallBack obtains a reference to every host to which it
delivers a callback, even if it is the origin host, so a reference is
leaked. Fix this by not ever passing a host to MultiBreakCallBack_r,
and just have MultiBreakCallBack_r release a reference for every host
to which it delivers a callback break.

FIXES 129376

Reviewed-on: http://gerrit.openafs.org/4581
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit af175ce2c7a4785ef1992d096adfdb27daa86ee4)

Change-Id: Ifd59c8ce93939f7b23e9f64bd7c0e527d3a2fa52
Reviewed-on: http://gerrit.openafs.org/4592
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/viced/callback.c