]> git.michaelhowe.org Git - packages/o/openafs.git/commit
Add safety checks on all hostList traversals
authorAndrew Deason <adeason@sinenomine.net>
Fri, 20 Nov 2009 20:15:28 +0000 (14:15 -0600)
committerDerrick Brashear <shadow|account-1000005@unknown>
Thu, 17 Dec 2009 17:52:00 +0000 (09:52 -0800)
commitdd55ac8ad042a1ddabdaf7ac0d4f6d7489402cb4
tree3cc03f590c2b2d66a59a78a95ccc7013475541bc
parent559718974e75d1348b9e18456dfa6fd099ad3419
Add safety checks on all hostList traversals

Currently, h_Enumerate checks that it doesn't enumerate over more than
hostCount hosts, in case the hostList has a cycle or is otherwise
corrupt. Add similar checks to all places in the code that loop over
hostList, to prevent the code from getting in an infinite loop under
H_LOCK in the case of a hostList cycle.

Also, ShutDownAndCore instead of assert'ing, so we try and detach
volumes first, possibly reducing salvaging time when we restart after
core'ing.

(cherry picked from 58258ba3b89732ea825e1aff2decab54347ab92e)
Change-Id: Ide1e5aca7c2c4a4af3f62bc07821db694f2f9999
Reviewed-on: http://gerrit.openafs.org/863
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Alistair Ferguson <alistair.ferguson@mac.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-on: http://gerrit.openafs.org/990
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
src/viced/host.c