]> git.michaelhowe.org Git - packages/o/openafs.git/commit
butc: avoid freeing uninitialized pointer in writeDbDump()
authorGarrett Wollman <wollman@csail.mit.edu>
Sun, 7 Aug 2011 03:55:50 +0000 (23:55 -0400)
committerDerrick Brashear <shadow@dementia.org>
Fri, 12 Aug 2011 15:51:30 +0000 (08:51 -0700)
commitf648519f2e7008d81a29113d6ce23158dcd37bcf
tree76d6ad922de99e11f5723e09a883d973ae075570
parentb8f95c1535538ddd4631a9b8d7286df030accc5a
butc: avoid freeing uninitialized pointer in writeDbDump()

In error conditions, charList could be freed before it is initialized.
Move the initialization up to before the error checks.

Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5167
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 43834bff1a2b1af348ff69d538a884bf1070b90c)

Change-Id: I05d1602b3f59b521d7daa3fd23f6609bf14c460e
Reviewed-on: http://gerrit.openafs.org/5224
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/butc/tcudbprocs.c