fsprobe: Get rid of unused hostname buffer

When we copy the user supplied hostname into the fixed length
hnamebuf array, we might overflow it. As we never use this buffer,
just get rid of it.

Caught by coverity (#985913)

Reviewed-on: http://gerrit.openafs.org/9394
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit b32d92268f77608b57adf350d963941a94a31604)

Change-Id: I09d119745dfdc9545af4912bd27f8ee09ccefd1f
Reviewed-on: http://gerrit.openafs.org/11042
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

diff --git a/src/viced/fsprobe.c b/src/viced/fsprobe.c
index 8f19df98663867a8348d492aa93a8bc0af5c6690..e6b014cc920424cca57437b716d5b808dc0a956a 100644 (file)
--- a/src/viced/fsprobe.c
+++ b/src/viced/fsprobe.c
@@ -63,7 +63,6 @@ main(int argc, char **argv)
     struct sockaddr_in host;
     afs_int32 code;
     struct hostent *hp;
-    char hnamebuf[200];
     struct timeval tv;
     int noAuth = 1;            /* Default is authenticated connections */
 
@@ -78,9 +77,7 @@ main(int argc, char **argv)
 #ifdef STRUCT_SOCKADDR_HAS_SA_LEN
     host.sin_len = sizeof(struct sockaddr_in);
 #endif
-    if (host.sin_addr.s_addr != -1) {
-       strcpy(hnamebuf, av[0]);
-    } else {
+    if (host.sin_addr.s_addr == -1) {
        hp = gethostbyname(av[0]);
        if (hp) {
            host.sin_family = hp->h_addrtype;