STABLE14-vnrehash-avoid-cachecheck-change-20050618

unlocking and locking lets us race and makes cacheCheck potentially go bad

diff --git a/src/vol/vnode.c b/src/vol/vnode.c
index 7f4876bbce8ec48f101ce0d7b27ffaf4ecea0c27..3e4b45df46c3857ae708cbb4513e3e02c30d9993 100644 (file)
--- a/src/vol/vnode.c
+++ b/src/vol/vnode.c
@@ -350,8 +350,10 @@ VAllocVnode_r(Error * ec, Volume * vp, VnodeType type)
            VOL_UNLOCK;
            ObtainWriteLock(&vnp->lock);
            VOL_LOCK;
-           if (vnp->volumePtr->cacheCheck != vnp->cacheCheck)
+           if (vnp->volumePtr->cacheCheck != vnp->cacheCheck) {
+               ReleaseWriteLock(&vnp->lock);
                goto vnrehash;
+           }
        }
 #ifdef AFS_PTHREAD_ENV
        vnp->writer = pthread_self();