To reference one element of a C-string use []

Reported by Marcus Watts

Pointer arithmetic is inappropriate when attempting to output
one of the elements of an array or C-string.

LICENSE IPL10

Reviewed-on: http://gerrit.openafs.org/90
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>

diff --git a/src/gtx/textobject.c b/src/gtx/textobject.c
index b589cba5034fde7f28628b2e121ad73717e658eb..9604558b9e38827d309bb18957e328ac764c3a6a 100644 (file)
--- a/src/gtx/textobject.c
+++ b/src/gtx/textobject.c
@@ -436,7 +436,7 @@ gator_text_Write(struct onode *onp, char *strToWrite, int numChars,
                "[%s:%s] Writing %d chars to text object at %p (highlight=%d, skip=%d: '",
                mn, rn, numChars, onp, highlight, skip);
        for (i = 0; i < numChars; i++)
-           fprintf(stderr, "%c", strToWrite + i);
+           fprintf(stderr, "%c", strToWrite[i]);
        fprintf(stderr, "\n");
     }