auth: Fix GetTokenEx with NULL cellName

If GetTokenEx is called with a NULL cellName, it means use the
local cell. To do this with the legacy interface, a 0 length string
must be used for the cell instance of the ktc_principal passed to
GetToken. Fix this so that we do so, rather than attempting to
strcpy(..., NULL) which never ends well.

Caught by clang-analyzer

Change-Id: I53d9bdf0fc280ee073a2fb7693659269df29c2eb
Reviewed-on: http://gerrit.openafs.org/7840
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>

diff --git a/src/auth/ktc.c b/src/auth/ktc.c
index 036bb6a3dbe0964843da97f2e444729ea3dff6bf..fc25636741566bc60b34d282178bf675e9be8fdc 100644 (file)
--- a/src/auth/ktc.c
+++ b/src/auth/ktc.c
@@ -487,7 +487,10 @@ ktc_GetTokenEx(char *cellName, struct ktc_setTokenData **tokenSet) {
        memset(ktcToken, 0, sizeof(struct ktc_token));
 
        strcpy(server.name, "afs");
-       strcpy(server.cell, cellName);
+
+       if (cellName != NULL)
+           strcpy(server.cell, cellName);
+
        code = GetToken(&server, ktcToken, sizeof(struct ktc_token),
                         NULL /*client*/, &viceid);
        if (code == 0) {