]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
vos: Do not try to remove backup volume id 0
authorAndrew Deason <adeason@sinenomine.net>
Mon, 9 Apr 2012 22:16:42 +0000 (17:16 -0500)
committerDerrick Brashear <shadow@dementix.org>
Wed, 8 Aug 2012 16:46:56 +0000 (09:46 -0700)
Currently we always try to delete a BK volume if we're deleting the
RW. If the BK volume id is 0, this is never going to do anything, so
don't try to delete it.

Reviewed-on: http://gerrit.openafs.org/7140
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 46bdb318c45b4e93a5b297e6fdee2b2acbed4b55)

Change-Id: I6d5406d6e39513d3f38e7674fa726b627ca5f1f0
Reviewed-on: http://gerrit.openafs.org/7935
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/volser/vsprocs.c

index 4630e9d66b74a3599dab9155430c478d9bbb160b..f6c8c1faf608ced4ac7418b28b227c6a7acfd54d 100644 (file)
@@ -1013,12 +1013,14 @@ UV_DeleteVolume(afs_uint32 aserver, afs_int32 apart, afs_uint32 avolid)
            ERROR_EXIT(0);
        }
 
-       /* Delete backup if it exists */
-       code = DoVolDelete(aconn, entry.volumeId[BACKVOL], apart,
-                          "the backup", 0, NULL, NULL);
-       if (code && code != VNOVOL) {
-           error = code;
-           goto error_exit;
+       if (entry.volumeId[BACKVOL]) {
+           /* Delete backup if it exists */
+           code = DoVolDelete(aconn, entry.volumeId[BACKVOL], apart,
+                              "the backup", 0, NULL, NULL);
+           if (code && code != VNOVOL) {
+               error = code;
+               goto error_exit;
+           }
        }
 
        if (verbose)