jbuelhler-flexelint-aggregate-initialization-patches-20031129

This patch mainly makes explicit some initializations that were implicit.

There are several places where it looks like the missing initialization
may be a bug, and I have inserted comments to that effect in the
relevant patches.  Someone needs to look at them and supply
whatever is missing (if anything is).

In make_keyperm.c, an array was sized too large.
--
Joe Buehler

diff --git a/src/WINNT/afsapplib/al_cover.cpp b/src/WINNT/afsapplib/al_cover.cpp
index b9639bdb76c3372576373fc61021407edfe33051..5a02c71fe38978c6a708137b39ba3886b23b31cc 100644 (file)
--- a/src/WINNT/afsapplib/al_cover.cpp
+++ b/src/WINNT/afsapplib/al_cover.cpp
@@ -21,10 +21,10 @@ extern "C" {
  */
 
 rwWindowData awdCover[] = {
-    { IDC_COVER_BORDER, raSizeX | raSizeY },
-    { IDC_COVER_DESC,   raSizeX | raSizeY | raRepaint },
-    { IDC_COVER_BUTTON, raMoveX | raMoveY | raRepaint },
-    { idENDLIST,        0 }
+    { IDC_COVER_BORDER, raSizeX | raSizeY,             0,      0 },
+    { IDC_COVER_DESC,   raSizeX | raSizeY | raRepaint, 0,      0 },
+    { IDC_COVER_BUTTON, raMoveX | raMoveY | raRepaint, 0,      0 },
+    { idENDLIST,        0,                             0,      0 }
  };
 
 #define WS_EX_HIDDENBYCOVER       0x10000000L

diff --git a/src/WINNT/afssvrcfg/create_partition_dlg.cpp b/src/WINNT/afssvrcfg/create_partition_dlg.cpp
index b591ea72424074df2c0147ab1ec3d9d9052f04ba..93f419befa3766e2f2e1835854df001e3e479ecc 100644 (file)
--- a/src/WINNT/afssvrcfg/create_partition_dlg.cpp
+++ b/src/WINNT/afssvrcfg/create_partition_dlg.cpp
@@ -40,16 +40,16 @@ static TCHAR szDrive[4];
 static TCHAR szSize[32];
 
 static rwWindowData arwDialog[] = {
-       { IDC_TITLE,                    raSizeX | raRepaint },
-       { IDC_DRIVE_LIST,               raSizeX | raSizeY, MAKELONG(350, 150) },
-       { IDC_ARGS_FRAME,               raSizeX | raMoveY },
-       { IDC_NAME_STATIC,              raMoveY | raRepaint },
-       { IDC_VICEP_STATIC,             raMoveY | raRepaint },
-       { IDC_PARTITION_NAME,   raMoveY | raRepaint },
-       { IDC_CREATE,                   raMoveX | raMoveY },
-       { IDC_CLOSE,                    raMoveX | raMoveY },
-       { 9,                                    raMoveX | raMoveY },
-       { idENDLIST,                    0 }
+       { IDC_TITLE,            raSizeX | raRepaint,    0,      0 },
+       { IDC_DRIVE_LIST,       raSizeX | raSizeY,      MAKELONG(350, 150), 0 },
+       { IDC_ARGS_FRAME,       raSizeX | raMoveY,      0,      0 },
+       { IDC_NAME_STATIC,      raMoveY | raRepaint,    0,      0 },
+       { IDC_VICEP_STATIC,     raMoveY | raRepaint,    0,      0 },
+       { IDC_PARTITION_NAME,   raMoveY | raRepaint,    0,      0 },
+       { IDC_CREATE,           raMoveX | raMoveY,      0,      0 },
+       { IDC_CLOSE,            raMoveX | raMoveY,      0,      0 },
+       { 9,                    raMoveX | raMoveY,      0,      0 },
+       { idENDLIST,            0,                      0,      0 }
 };
 
 

diff --git a/src/WINNT/afssvrcfg/salvage_results_dlg.cpp b/src/WINNT/afssvrcfg/salvage_results_dlg.cpp
index 615feb525182ad6f8851595dc1669f96369b5ec0..41e983917010e1876867ee8d37ff5abd3cd7146e 100644 (file)
--- a/src/WINNT/afssvrcfg/salvage_results_dlg.cpp
+++ b/src/WINNT/afssvrcfg/salvage_results_dlg.cpp
@@ -29,10 +29,10 @@ static const int     EDIT_CONTROL_MAX_CHARS = 64000;            // Max chars an
 static const char   *SALVAGE_LOG_FILE_NAME  = "SalvageLog.txt";
 
 static rwWindowData arwDialog[] = {
-       { IDC_LOG,                              raSizeX | raSizeY, MAKELONG(350, 150) },
-       { IDC_CLOSE,                    raMoveX | raMoveY },
-       { 9,                                    raMoveX | raMoveY },
-       { idENDLIST,                    0 }
+       { IDC_LOG,      raSizeX | raSizeY,      MAKELONG(350, 150), 0 },
+       { IDC_CLOSE,    raMoveX | raMoveY,      0,      0 },
+       { 9,            raMoveX | raMoveY,      0,      0 },
+       { idENDLIST,    0,                      0,      0 }
 };
 
 

diff --git a/src/WINNT/afssvrmgr/action.cpp b/src/WINNT/afssvrmgr/action.cpp
index 560818ebd79f7ac29e4ffe8789ecfbfe7bc3482a..4f93017213025e248969cf4664692d0f8d23ab1f 100644 (file)
--- a/src/WINNT/afssvrmgr/action.cpp
+++ b/src/WINNT/afssvrmgr/action.cpp
@@ -118,9 +118,9 @@ static struct l
    } l;
 
 rwWindowData awdActions[] = {
-    { IDC_ACTION_DESC,     raSizeX | raRepaint },
-    { IDC_ACTION_LIST,     raSizeX | raSizeY,   MAKELONG(cxMIN_ACTION,cyMIN_ACTION) },
-    { idENDLIST,           0                   }
+    { IDC_ACTION_DESC,     raSizeX | raRepaint,        0,                                      0 },
+    { IDC_ACTION_LIST,     raSizeX | raSizeY,   MAKELONG(cxMIN_ACTION,cyMIN_ACTION),   0 },
+    { idENDLIST,           0,                  0,                                      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/agg_tab.cpp b/src/WINNT/afssvrmgr/agg_tab.cpp
index 290709f567230cc645ad53771cba6b8b0ed0f5f0..a4ac9150d7c38aec308b152937eaa6b005cf8c36 100644 (file)
--- a/src/WINNT/afssvrmgr/agg_tab.cpp
+++ b/src/WINNT/afssvrmgr/agg_tab.cpp
@@ -27,10 +27,10 @@ extern "C" {
  */
 
 rwWindowData awdAggregates[] = {
-    { IDC_AGG_DESC,        raSizeX           },
-    { IDC_AGG_LIST,        raSizeX | raSizeY },
-    { IDC_AGG_CREATESET,   raMoveX | raMoveY },
-    { idENDLIST,           0                 }
+    { IDC_AGG_DESC,        raSizeX,            0,      0 },
+    { IDC_AGG_LIST,        raSizeX | raSizeY,  0,      0 },
+    { IDC_AGG_CREATESET,   raMoveX | raMoveY,  0,      0 },
+    { idENDLIST,           0,                  0,      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/cmdline.cpp b/src/WINNT/afssvrmgr/cmdline.cpp
index 2293027682bf041ac62f7520dcbfa15a8892a6c4..8576bc269ae2a22328d87877211a7b8a86719dd3 100644 (file)
--- a/src/WINNT/afssvrmgr/cmdline.cpp
+++ b/src/WINNT/afssvrmgr/cmdline.cpp
@@ -43,15 +43,15 @@ static struct {
    BOOL fPresent;
    TCHAR szValue[ cchRESOURCE ];
 } aSWITCHES[] = {
-   { TEXT("cell"),        TRUE  },
-   { TEXT("subset"),      TRUE  },
-   { TEXT("server"),      TRUE  },
-   { TEXT("reset"),       FALSE },
-   { TEXT("confirm"),     FALSE },
-   { TEXT("user"),        TRUE  },
-   { TEXT("password"),    TRUE  },
-   { TEXT("lookup"),      FALSE },
-   { TEXT("useexisting"), FALSE }
+   { TEXT("cell"),        TRUE,                FALSE,  TEXT("") },
+   { TEXT("subset"),      TRUE,                FALSE,  TEXT("") },
+   { TEXT("server"),      TRUE,                FALSE,  TEXT("") },
+   { TEXT("reset"),       FALSE,       FALSE,  TEXT("") },
+   { TEXT("confirm"),     FALSE,       FALSE,  TEXT("") },
+   { TEXT("user"),        TRUE,                FALSE,  TEXT("") },
+   { TEXT("password"),    TRUE,                FALSE,  TEXT("") },
+   { TEXT("lookup"),      FALSE,       FALSE,  TEXT("") },
+   { TEXT("useexisting"), FALSE,       FALSE,  TEXT("") }
 };
 
 #define nSWITCHES (sizeof(aSWITCHES) / sizeof(aSWITCHES[0]))

diff --git a/src/WINNT/afssvrmgr/columns.cpp b/src/WINNT/afssvrmgr/columns.cpp
index 8ae99105c365a35ba05b81dd191bf29fa07dbbdc..50a1c4febef31e640f77aac13f37dd158cfd9c30 100644 (file)
--- a/src/WINNT/afssvrmgr/columns.cpp
+++ b/src/WINNT/afssvrmgr/columns.cpp
@@ -62,14 +62,14 @@ static struct
    }
 COLUMNS[] =
    {
-      { IDS_COL_SERVERS,      FALSE  },  // ceSERVERS
-      { IDS_COL_FILESETS,     FALSE  },  // ceFILESETS
-      { IDS_COL_AGGREGATES,   FALSE  },  // ceAGGREGATES
-      { IDS_COL_SERVICES,     FALSE  },  // ceSERVICES
-      { IDS_COL_REPLICAS,     FALSE  },  // ceREPLICAS
-      { IDS_COL_AGGS_MOVE,    TRUE   },  // ceAGG_MOVE
-      { IDS_COL_AGGS_CREATE,  TRUE   },  // ceAGG_CREATE
-      { IDS_COL_AGGS_RESTORE, TRUE   }   // ceAGG_RESTORE
+      { IDS_COL_SERVERS,      FALSE,   {0},    FALSE  },  // ceSERVERS
+      { IDS_COL_FILESETS,     FALSE,   {0},    FALSE  },  // ceFILESETS
+      { IDS_COL_AGGREGATES,   FALSE,   {0},    FALSE  },  // ceAGGREGATES
+      { IDS_COL_SERVICES,     FALSE,   {0},    FALSE  },  // ceSERVICES
+      { IDS_COL_REPLICAS,     FALSE,   {0},    FALSE  },  // ceREPLICAS
+      { IDS_COL_AGGS_MOVE,    TRUE,            {0},    FALSE  },  // ceAGG_MOVE
+      { IDS_COL_AGGS_CREATE,  TRUE,            {0},    FALSE  },  // ceAGG_CREATE
+      { IDS_COL_AGGS_RESTORE, TRUE,            {0},    FALSE  }   // ceAGG_RESTORE
    };
 
 #define nCOLUMNS (sizeof(COLUMNS)/sizeof(COLUMNS[0]))

diff --git a/src/WINNT/afssvrmgr/set_tab.cpp b/src/WINNT/afssvrmgr/set_tab.cpp
index 7ce28ef8e97a6342c3de0083da922f1c048528a9..9d6cab3cba891bd7e34c2c5888105eae47964b78 100644 (file)
--- a/src/WINNT/afssvrmgr/set_tab.cpp
+++ b/src/WINNT/afssvrmgr/set_tab.cpp
@@ -34,13 +34,13 @@ extern "C" {
  */
 
 rwWindowData awdFilesets[] = {
-    { IDC_SET_DESC,        raSizeX           },
-    { IDC_SET_LIST,        raSizeX | raSizeY },
-    { IDC_SET_CREATE,      raMoveX | raMoveY },
-    { IDC_SET_DELETE,      raMoveX | raMoveY },
-    { IDC_SET_REP,         raMoveX | raMoveY },
-    { IDC_SET_SETQUOTA,    raMoveX | raMoveY },
-    { idENDLIST,           0                 }
+    { IDC_SET_DESC,        raSizeX,            0,      0 },
+    { IDC_SET_LIST,        raSizeX | raSizeY,  0,      0 },
+    { IDC_SET_CREATE,      raMoveX | raMoveY,  0,      0 },
+    { IDC_SET_DELETE,      raMoveX | raMoveY,  0,      0 },
+    { IDC_SET_REP,         raMoveX | raMoveY,  0,      0 },
+    { IDC_SET_SETQUOTA,    raMoveX | raMoveY,  0,      0 },
+    { idENDLIST,           0,                  0,      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/svc_tab.cpp b/src/WINNT/afssvrmgr/svc_tab.cpp
index 0227dcc2718b6e33654abc65329f3f0a2008b3de..4dfc9748acffa2343407fce6711c9eb125787816 100644 (file)
--- a/src/WINNT/afssvrmgr/svc_tab.cpp
+++ b/src/WINNT/afssvrmgr/svc_tab.cpp
@@ -26,12 +26,12 @@ extern "C" {
  */
 
 rwWindowData awdServices[] = {
-    { IDC_SVC_DESC,        raSizeX           },
-    { IDC_SVC_LIST,        raSizeX | raSizeY },
-    { IDC_SVC_CREATE,      raMoveX | raMoveY },
-    { IDC_SVC_DELETE,      raMoveX | raMoveY },
-    { IDC_SVC_RESTART,     raMoveX | raMoveY },
-    { idENDLIST,           0                 }
+    { IDC_SVC_DESC,        raSizeX,            0,      0 },
+    { IDC_SVC_LIST,        raSizeX | raSizeY,  0,      0 },
+    { IDC_SVC_CREATE,      raMoveX | raMoveY,  0,      0 },
+    { IDC_SVC_DELETE,      raMoveX | raMoveY,  0,      0 },
+    { IDC_SVC_RESTART,     raMoveX | raMoveY,  0,      0 },
+    { idENDLIST,           0,                  0,      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/svc_viewlog.cpp b/src/WINNT/afssvrmgr/svc_viewlog.cpp
index a73689fed467e7f4b3862ded7a4f21fd7d7b5939..7cbc57d133d749126f154158e7a43f3def59da35 100644 (file)
--- a/src/WINNT/afssvrmgr/svc_viewlog.cpp
+++ b/src/WINNT/afssvrmgr/svc_viewlog.cpp
@@ -30,13 +30,13 @@ extern "C" {
  */
 
 rwWindowData awdShowLog[] = {
-    { IDC_SVC_VIEWLOG_DESC,     raSizeX | raRepaint },
-    { IDC_SVC_VIEWLOG_FILENAME, raSizeX | raRepaint },
-    { IDC_VIEWLOG_TEXT,         raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_VIEWLOG,cyMIN_VIEWLOG) },
-    { IDC_SVC_VIEWLOG_CONTENTS, raSizeX },
-    { IDOK,                     raMoveX | raMoveY },
-    { IDC_VIEWLOG_SAVEAS,       raMoveX | raMoveY },
-    { idENDLIST, 0 }
+    { IDC_SVC_VIEWLOG_DESC,     raSizeX | raRepaint,           0,      0 },
+    { IDC_SVC_VIEWLOG_FILENAME, raSizeX | raRepaint,           0,      0 },
+    { IDC_VIEWLOG_TEXT,         raSizeX | raSizeY | raRepaint,         MAKELONG(cxMIN_VIEWLOG,cyMIN_VIEWLOG),  0 },
+    { IDC_SVC_VIEWLOG_CONTENTS, raSizeX,                       0,      0 },
+    { IDOK,                     raMoveX | raMoveY,             0,      0 },
+    { IDC_VIEWLOG_SAVEAS,       raMoveX | raMoveY,             0,      0 },
+    { idENDLIST, 0,                                            0,      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/svr_salvage.cpp b/src/WINNT/afssvrmgr/svr_salvage.cpp
index c08ae7a5b60770d34ab345a8c4a78681afd50592..2cc46ba14034b805407574b52ea8d5ed08bb7167 100644 (file)
--- a/src/WINNT/afssvrmgr/svr_salvage.cpp
+++ b/src/WINNT/afssvrmgr/svr_salvage.cpp
@@ -32,10 +32,10 @@ extern "C" {
  */
 
 rwWindowData awdSalvageResults[] = {
-    { IDC_SALVAGE_TITLE,        raSizeX | raRepaint },
-    { IDC_SALVAGE_DETAILS,      raSizeX | raSizeY | raRepaint, MAKELONG(cxMIN_SALVAGE_R,cyMIN_SALVAGE_R) },
-    { IDOK,                     raMoveX | raMoveY },
-    { idENDLIST, 0 }
+    { IDC_SALVAGE_TITLE,        raSizeX | raRepaint,           0,      0 },
+    { IDC_SALVAGE_DETAILS,      raSizeX | raSizeY | raRepaint,         MAKELONG(cxMIN_SALVAGE_R,cyMIN_SALVAGE_R), 0 },
+    { IDOK,                     raMoveX | raMoveY,             0,      0 },
+    { idENDLIST, 0,                                            0,      0 }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/svr_window.cpp b/src/WINNT/afssvrmgr/svr_window.cpp
index 0cd18811f039d2ab83d44876a940f91628c9b92c..d57f07008c22815ca233608f883f7ba0efa54888 100644 (file)
--- a/src/WINNT/afssvrmgr/svr_window.cpp
+++ b/src/WINNT/afssvrmgr/svr_window.cpp
@@ -31,13 +31,13 @@ extern "C" {
 #define cyMIN_SERVER 100
 
 static rwWindowData awdServer[] = {
-    { IDC_TABS,  raSizeX | raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) },
-    { idENDLIST, 0 }
+    { IDC_TABS,  raSizeX | raSizeY,    MAKELONG(cxMIN_SERVER,cyMIN_SERVER),    0 },
+    { idENDLIST, 0,                    0,                                      0 }
  };
 
 static rwWindowData awdTabChild[] = {
-    { 0,         raSizeX | raSizeY },
-    { idENDLIST, 0  }
+    { 0,         raSizeX | raSizeY,    0,      0 },
+    { idENDLIST, 0,                    0,      0  }
  };
 
 

diff --git a/src/WINNT/afssvrmgr/window.cpp b/src/WINNT/afssvrmgr/window.cpp
index dc129b5b8874771e477a229070711ebcd6b15d4b..473dd50c6d55078fe3a943f9c0b210b2aec0683b 100644 (file)
--- a/src/WINNT/afssvrmgr/window.cpp
+++ b/src/WINNT/afssvrmgr/window.cpp
@@ -47,48 +47,48 @@ extern "C" {
 #define cyMIN_WINDOW  120
 
 rwWindowData awdMain[] = {
-    { IDC_CELL_BORDER, raSizeX             },
-    { IDC_CELL,        raSizeX | raRepaint },
-    { IDC_AFS_ID,      raSizeX | raRepaint },
-    { IDC_SERVERS,     raSizeX | raSizeY,  MAKELONG(cxMIN_SERVER,cyMIN_SERVER) },
-    { IDC_COVERDLG,    raSizeX | raSizeY   },
-    { IDC_ANIMATE,     raMoveX             },
-    { idENDLIST,       0                   }
+    { IDC_CELL_BORDER, raSizeX,                        0,      0 },
+    { IDC_CELL,        raSizeX | raRepaint,    0,      0 },
+    { IDC_AFS_ID,      raSizeX | raRepaint,    0,      0 },
+    { IDC_SERVERS,     raSizeX | raSizeY,      MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 },
+    { IDC_COVERDLG,    raSizeX | raSizeY,      0,      0 },
+    { IDC_ANIMATE,     raMoveX,                        0,      0 },
+    { idENDLIST,       0,                      0,      0 }
  };
 
 rwWindowData awdMainVert[] = {
-    { IDC_CELL_BORDER,     raSizeX                       },
-    { IDC_CELL,            raSizeX | raRepaint           },
-    { IDC_AFS_ID,          raSizeX | raRepaint           },
-    { IDC_SERVERS,         raSizeX, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) },
-    { IDC_SPLITTER_SERVER, raSizeX                       },
-    { IDC_TABS,            raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) },
-    { IDC_COVERDLG,        raSizeX                       },
-    { IDC_ANIMATE,         raMoveX                       },
-    { idENDLIST,           0                             }
+    { IDC_CELL_BORDER,     raSizeX,            0,      0 },
+    { IDC_CELL,            raSizeX | raRepaint,        0,      0 },
+    { IDC_AFS_ID,          raSizeX | raRepaint,        0,      0 },
+    { IDC_SERVERS,         raSizeX,            MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 },
+    { IDC_SPLITTER_SERVER, raSizeX,            0,      0 },
+    { IDC_TABS,            raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 },
+    { IDC_COVERDLG,        raSizeX,             0,     0 },
+    { IDC_ANIMATE,         raMoveX,             0,     0 },
+    { idENDLIST,           0,                  0,      0  }
  };
 
 rwWindowData awdMainHorz[] = {
-    { IDC_CELL_BORDER,     raSizeX                       },
-    { IDC_CELL,            raSizeX  | raRepaint          },
-    { IDC_AFS_ID,          raSizeX  | raRepaint          },
-    { IDC_SERVERS,         raSizeY, MAKELONG(cxMIN_SERVER,cyMIN_SERVER) },
-    { IDC_SPLITTER_SERVER, raSizeY                       },
-    { IDC_TABS,            raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) },
-    { IDC_COVERDLG,        raSizeY                       },
-    { IDC_ANIMATE,         raMoveX                       },
-    { idENDLIST,           0                             }
+    { IDC_CELL_BORDER,     raSizeX,                    0,      0 },
+    { IDC_CELL,            raSizeX  | raRepaint,       0,      0 },
+    { IDC_AFS_ID,          raSizeX  | raRepaint,       0,      0 },
+    { IDC_SERVERS,         raSizeY,                    MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 },
+    { IDC_SPLITTER_SERVER, raSizeY,                    0,      0 },
+    { IDC_TABS,            raSizeX | raSizeY,          MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 },
+    { IDC_COVERDLG,        raSizeY,                    0,      0 },
+    { IDC_ANIMATE,         raMoveX,                    0,      0 },
+    { idENDLIST,           0,                          0,      0 }
  };
 
 rwWindowData awdSplitServer[] = {
-    { IDC_CELL,            raRepaint },
-    { IDC_AFS_ID,          raRepaint },
-    { IDC_SERVERS,         raSizeX | raSizeY,  MAKELONG(cxMIN_SERVER,cyMIN_SERVER) },
-    { IDC_SPLITTER_SERVER, raMoveX | raMoveY },
-    { IDC_TABS,            raMoveX | raMoveY | raSizeXB | raSizeYB, MAKELONG(cxMIN_TABS,cyMIN_TABS) },
-    { IDC_COVERDLG,        raSizeX | raSizeY },
-    { IDC_ANIMATE,         0  },
-    { idENDLIST,           0  }
+    { IDC_CELL,            raRepaint,                  0,      0 },
+    { IDC_AFS_ID,          raRepaint,                  0,      0 },
+    { IDC_SERVERS,         raSizeX | raSizeY,          MAKELONG(cxMIN_SERVER,cyMIN_SERVER), 0 },
+    { IDC_SPLITTER_SERVER, raMoveX | raMoveY,          0,      0 },
+    { IDC_TABS,            raMoveX | raMoveY | raSizeXB | raSizeYB, MAKELONG(cxMIN_TABS,cyMIN_TABS), 0 },
+    { IDC_COVERDLG,        raSizeX | raSizeY,          0,      0 },
+    { IDC_ANIMATE,         0,                          0,      0 },
+    { idENDLIST,           0,                          0,      0 }
  };
 
 

diff --git a/src/WINNT/afsusrmgr/action.cpp b/src/WINNT/afsusrmgr/action.cpp
index 48d48970b45d7c474904b57d5a394213f2cd160c..22bfb76b7c352deb9f07b4e5f61ec595d7a09887 100644 (file)
--- a/src/WINNT/afsusrmgr/action.cpp
+++ b/src/WINNT/afsusrmgr/action.cpp
@@ -59,9 +59,9 @@ static struct
    } l;
 
 rwWindowData awdActions[] = {
-    { IDC_ACTION_DESC, raSizeX | raRepaint },
-    { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION) },
-    { idENDLIST, 0 }
+    { IDC_ACTION_DESC, raSizeX | raRepaint,                                    0,      0 },
+    { IDC_ACTION_LIST, raSizeX | raSizeY, MAKELONG(cxMIN_ACTION,cyMIN_ACTION), 0 },
+    { idENDLIST, 0,                                                            0,      0 }
  };
 
 

diff --git a/src/WINNT/afsusrmgr/cmdline.cpp b/src/WINNT/afsusrmgr/cmdline.cpp
index cd3d950d0db57fa39c59515d424bcbba406e8aa3..36abdb6e48324fbac200420216784e34ce4dbff5 100644 (file)
--- a/src/WINNT/afsusrmgr/cmdline.cpp
+++ b/src/WINNT/afsusrmgr/cmdline.cpp
@@ -38,10 +38,10 @@ static struct {
    BOOL fPresent;
    TCHAR szValue[ cchRESOURCE ];
 } aSWITCHES[] = {
-   { TEXT("cell"),      TRUE  },
-   { TEXT("remote"),    TRUE  },
-   { TEXT("user"),      TRUE  },
-   { TEXT("password"),  TRUE  }
+   { TEXT("cell"),      TRUE,  FALSE,  TEXT("") },
+   { TEXT("remote"),    TRUE,  FALSE,  TEXT("") },
+   { TEXT("user"),      TRUE,  FALSE,  TEXT("") },
+   { TEXT("password"),  TRUE,  FALSE,  TEXT("") }
 };
 
 #define nSWITCHES (sizeof(aSWITCHES) / sizeof(aSWITCHES[0]))

diff --git a/src/WINNT/afsusrmgr/columns.cpp b/src/WINNT/afsusrmgr/columns.cpp
index fb3e8fef656fe926cf73913ea43916d3a0c28722..16eeefea33c0451bde18f8fdb0bee9a88813ca50 100644 (file)
--- a/src/WINNT/afsusrmgr/columns.cpp
+++ b/src/WINNT/afsusrmgr/columns.cpp
@@ -55,9 +55,9 @@ static struct
    }
 COLUMNS[] =
    {
-      { IDS_COL_USERS,        FALSE  },  // ceUSERS
-      { IDS_COL_GROUPS,       FALSE  },  // ceGROUPS
-      { IDS_COL_MACHINES,     FALSE  },  // ceMACHINES
+      { IDS_COL_USERS,        FALSE,   {0},    FALSE },  // ceUSERS
+      { IDS_COL_GROUPS,       FALSE,   {0},    FALSE },  // ceGROUPS
+      { IDS_COL_MACHINES,     FALSE,   {0},    FALSE },  // ceMACHINES
    };
 
 #define nCOLUMNS (sizeof(COLUMNS)/sizeof(COLUMNS[0]))

diff --git a/src/WINNT/afsusrmgr/grp_tab.cpp b/src/WINNT/afsusrmgr/grp_tab.cpp
index 8c503da52b91e194e558ce14dc88ca1ba35c5bf2..024f234cecfe9888e469d1c703aabfefe763532c 100644 (file)
--- a/src/WINNT/afsusrmgr/grp_tab.cpp
+++ b/src/WINNT/afsusrmgr/grp_tab.cpp
@@ -25,16 +25,16 @@ extern "C" {
  */
 
 rwWindowData awdGroupsTab[] = {
-    { IDC_GROUPS_TITLE, raRepaint | raSizeX },
-    { IDC_ADVANCED, raMoveX },
-    { IDC_GROUPS_PATTERN, raMoveX },
-    { IDC_GROUPS_PATTERN_PROMPT, raRepaint | raMoveX },
-    { IDC_GROUPS_LIST, raSizeX | raSizeY },
-    { M_GROUP_CREATE, raMoveX | raMoveY },
-    { M_MEMBERSHIP, raMoveX | raMoveY },
-    { M_PROPERTIES, raMoveX | raMoveY },
-    { IDC_STATIC, raRepaint },
-    { idENDLIST, 0 }
+    { IDC_GROUPS_TITLE, raRepaint | raSizeX,           0,      0 },
+    { IDC_ADVANCED, raMoveX,                           0,      0 },
+    { IDC_GROUPS_PATTERN, raMoveX,                     0,      0 },
+    { IDC_GROUPS_PATTERN_PROMPT, raRepaint | raMoveX,  0,      0 },
+    { IDC_GROUPS_LIST, raSizeX | raSizeY,              0,      0 },
+    { M_GROUP_CREATE, raMoveX | raMoveY,               0,      0 },
+    { M_MEMBERSHIP, raMoveX | raMoveY,                 0,      0 },
+    { M_PROPERTIES, raMoveX | raMoveY,                 0,      0 },
+    { IDC_STATIC, raRepaint,                           0,      0 },
+    { idENDLIST, 0,                                    0,      0 }
  };
 
 

diff --git a/src/WINNT/afsusrmgr/mch_tab.cpp b/src/WINNT/afsusrmgr/mch_tab.cpp
index ba031e29154fca10e1fa1c1aa9f4009819d3b12d..116117a03cd2198eee4fb5a16fd29c93e0f2efdd 100644 (file)
--- a/src/WINNT/afsusrmgr/mch_tab.cpp
+++ b/src/WINNT/afsusrmgr/mch_tab.cpp
@@ -25,16 +25,16 @@ extern "C" {
  */
 
 rwWindowData awdMachinesTab[] = {
-    { IDC_MACHINES_TITLE, raRepaint | raSizeX },
-    { IDC_ADVANCED, raMoveX },
-    { IDC_MACHINES_PATTERN, raMoveX },
-    { IDC_MACHINES_PATTERN_PROMPT, raRepaint | raMoveX },
-    { IDC_MACHINES_LIST, raSizeX | raSizeY },
-    { M_MACHINE_CREATE, raMoveX | raMoveY },
-    { M_MEMBERSHIP, raMoveX | raMoveY },
-    { M_PROPERTIES, raMoveX | raMoveY },
-    { IDC_STATIC, raRepaint },
-    { idENDLIST, 0 }
+    { IDC_MACHINES_TITLE, raRepaint | raSizeX,         0,      0 },
+    { IDC_ADVANCED, raMoveX,                           0,      0 },
+    { IDC_MACHINES_PATTERN, raMoveX,                   0,      0 },
+    { IDC_MACHINES_PATTERN_PROMPT, raRepaint | raMoveX,        0,      0 },
+    { IDC_MACHINES_LIST, raSizeX | raSizeY,            0,      0 },
+    { M_MACHINE_CREATE, raMoveX | raMoveY,             0,      0 },
+    { M_MEMBERSHIP, raMoveX | raMoveY,                 0,      0 },
+    { M_PROPERTIES, raMoveX | raMoveY,                 0,      0 },
+    { IDC_STATIC, raRepaint,                           0,      0 },
+    { idENDLIST, 0,                                    0,      0 }
  };
 
 

diff --git a/src/WINNT/afsusrmgr/usr_tab.cpp b/src/WINNT/afsusrmgr/usr_tab.cpp
index fde6316ad7d3ecf909c6f216d8e6fe700802aa40..d8541bd3d61668ff572096a125955aefd65c6407 100644 (file)
--- a/src/WINNT/afsusrmgr/usr_tab.cpp
+++ b/src/WINNT/afsusrmgr/usr_tab.cpp
@@ -26,16 +26,16 @@ extern "C" {
  */
 
 rwWindowData awdUsersTab[] = {
-    { IDC_USERS_TITLE, raRepaint | raSizeX },
-    { IDC_ADVANCED, raMoveX },
-    { IDC_USERS_PATTERN, raMoveX },
-    { IDC_USERS_PATTERN_PROMPT, raRepaint | raMoveX },
-    { IDC_USERS_LIST, raSizeX | raSizeY },
-    { M_USER_CREATE, raMoveX | raMoveY },
-    { M_MEMBERSHIP, raMoveX | raMoveY },
-    { M_PROPERTIES, raMoveX | raMoveY },
-    { IDC_STATIC, raRepaint },
-    { idENDLIST, 0 }
+    { IDC_USERS_TITLE, raRepaint | raSizeX,            0,      0 },
+    { IDC_ADVANCED, raMoveX,                           0,      0 },
+    { IDC_USERS_PATTERN, raMoveX,                      0,      0 },
+    { IDC_USERS_PATTERN_PROMPT, raRepaint | raMoveX,   0,      0 },
+    { IDC_USERS_LIST, raSizeX | raSizeY,               0,      0 },
+    { M_USER_CREATE, raMoveX | raMoveY,                        0,      0 },
+    { M_MEMBERSHIP, raMoveX | raMoveY,                 0,      0 },
+    { M_PROPERTIES, raMoveX | raMoveY,                 0,      0 },
+    { IDC_STATIC, raRepaint,                           0,      0 },
+    { idENDLIST, 0,                                    0,      0 }
  };
 
 

diff --git a/src/WINNT/afsusrmgr/window.cpp b/src/WINNT/afsusrmgr/window.cpp
index db5638493b6bbaaf6e19ddf9cd8c7832f99882d4..f6e6f8d8ea81cef1ff2af84eb3b555e7d7f8a918 100644 (file)
--- a/src/WINNT/afsusrmgr/window.cpp
+++ b/src/WINNT/afsusrmgr/window.cpp
@@ -52,18 +52,18 @@ static size_t cTABS = sizeof(aTABS) / sizeof(aTABS[0]);
 #define cyMIN_TABS    100
 
 rwWindowData awdMain[] = {
-   { IDC_TAB, raSizeX | raSizeY, MAKELONG(cxMIN_TABS,cyMIN_TABS) },
-   { IDC_CELL, raSizeX | raRepaint },
-   { IDC_CREDS, raSizeX | raRepaint },
-   { IDC_ANIM, raMoveX },
-   { IDC_BAR, raSizeX },
-   { IDC_STATIC, raRepaint },
-   { idENDLIST, 0 }
+   { IDC_TAB, raSizeX | raSizeY,               MAKELONG(cxMIN_TABS,cyMIN_TABS),        0 },
+   { IDC_CELL, raSizeX | raRepaint,            0,                                                                      0 },
+   { IDC_CREDS, raSizeX | raRepaint,   0,                                                                      0 },
+   { IDC_ANIM, raMoveX,                                        0,                                                                      0 },
+   { IDC_BAR, raSizeX,                                 0,                                                                      0 },
+   { IDC_STATIC, raRepaint,                            0,                                                                      0 },
+   { idENDLIST, 0,                                             0,                                                                      0 }
 };
 
 rwWindowData awdTabChild[] = {
-    { 0, raSizeX | raSizeY },
-    { idENDLIST, 0  }
+    { 0, raSizeX | raSizeY,                                                            0,      0 },
+    { idENDLIST, 0,                                                                            0,      0 }
  };
 
 

diff --git a/src/WINNT/client_creds/afswiz.cpp b/src/WINNT/client_creds/afswiz.cpp
index fa67b5e0b3330e039f0e82d228c02ab23a2198ad..65b942c0c4ab27b23e5a9f079de56c43214ee8c5 100644 (file)
--- a/src/WINNT/client_creds/afswiz.cpp
+++ b/src/WINNT/client_creds/afswiz.cpp
@@ -75,12 +75,12 @@ typedef enum
    } WIZSTEP;
 
 static WIZARD_STATE aStates[] = {
-   { STEP_START,     IDD_WIZ_START,     WizStart_DlgProc     },
-   { STEP_STARTING,  IDD_WIZ_STARTING,  WizStarting_DlgProc  },
-   { STEP_CREDS,     IDD_WIZ_CREDS,     WizCreds_DlgProc     },
-   { STEP_MOUNT,     IDD_WIZ_MOUNT,     WizMount_DlgProc     },
-   { STEP_MOUNTING,  IDD_WIZ_MOUNTING,  WizMounting_DlgProc  },
-   { STEP_FINISH,    IDD_WIZ_FINISH,    WizFinish_DlgProc    },
+   { STEP_START,     IDD_WIZ_START,     WizStart_DlgProc,      0 },
+   { STEP_STARTING,  IDD_WIZ_STARTING,  WizStarting_DlgProc,   0 },
+   { STEP_CREDS,     IDD_WIZ_CREDS,     WizCreds_DlgProc,      0 },
+   { STEP_MOUNT,     IDD_WIZ_MOUNT,     WizMount_DlgProc,      0 },
+   { STEP_MOUNTING,  IDD_WIZ_MOUNTING,  WizMounting_DlgProc,   0 },
+   { STEP_FINISH,    IDD_WIZ_FINISH,    WizFinish_DlgProc,     0 }
 };
 
 static const int cStates = sizeof(aStates) / sizeof(aStates[0]);

diff --git a/src/budb/ol_verify.c b/src/budb/ol_verify.c
index 9787c3d6789ba98f82665ad10e40aeac8a9d6bb3..2b078e5a829a221ba529b3dde87da316a6cda5c6 100644 (file)
--- a/src/budb/ol_verify.c
+++ b/src/budb/ol_verify.c
@@ -148,6 +148,7 @@ int blockEntrySize[NBLOCKTYPES] = {
     sizeof(((struct tBlock *) NULL)->a[0]),
     sizeof(((struct dBlock *) NULL)->a[0]),
     0
+    /* FIXME: possible missing initializer here */
 };
 
 char *typeName[NBLOCKTYPES] = {
@@ -157,6 +158,7 @@ char *typeName[NBLOCKTYPES] = {
     "tape",
     "dump",
     "hashTable"
+    /* FIXME: possible missing initializer here */
 };
 
 int hashBlockType[HT_MAX_FUNCTION + 1] = {
@@ -165,6 +167,7 @@ int hashBlockType[HT_MAX_FUNCTION + 1] = {
     dump_BLOCK,
     tape_BLOCK,
     volInfo_BLOCK
+    /* FIXME: possible missing initializer here */
 };
 
 /* Compatibility table for the bits in the blockMap. */

diff --git a/src/des/make_keyperm.c b/src/des/make_keyperm.c
index f34be75b59ae2d9f44869ac0170568830a53d29d..e8fdb9cb3338e0418ea7b26a8fa046a63de6e55f 100644 (file)
--- a/src/des/make_keyperm.c
+++ b/src/des/make_keyperm.c
@@ -48,7 +48,7 @@ static int const shift[16 + 1] = { 0,
     1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1,
 };
 
-static int const pc_1[64 + 1] = { 0,
+static int const pc_1[56 + 1] = { 0,
 
     57, 49, 41, 33, 25, 17, 9,
     1, 58, 50, 42, 34, 26, 18,

diff --git a/src/rxkad/rxkad_server.c b/src/rxkad/rxkad_server.c
index b09f9f6983c4a7adda364b9a33e11cba331730a7..6a4c32b5692f4e1fee9b0fbf935ffaa56ee1b401 100644 (file)
--- a/src/rxkad/rxkad_server.c
+++ b/src/rxkad/rxkad_server.c
@@ -59,6 +59,9 @@ static struct rx_securityOps rxkad_server_ops = {
     rxkad_CheckPacket,         /* check data packet */
     rxkad_DestroyConnection,
     rxkad_GetStats,
+       0, /* spare 1 */
+       0, /* spare 2 */
+       0, /* spare 3 */
 };
 extern afs_uint32 rx_MyMaxSendSize;
 

diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c
index 2f46a07bce5ff777c99a4a71c81e3426b6d72271..1d2415202e93fe12025405b385e6f33354337d35 100644 (file)
--- a/src/vol/vol-salvage.c
+++ b/src/vol/vol-salvage.c
@@ -397,7 +397,7 @@ typedef struct {
 } childJob_t;
 
 /* Child job this process is running. */
-childJob_t myjob = { SALVAGER_MAGIC, NOT_CHILD };
+childJob_t myjob = { SALVAGER_MAGIC, NOT_CHILD, "" };
 
 int nt_SalvagePartition(char *partName, int jobn);
 int nt_SetupPartitionSalvage(void *datap, int len);