]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
libafscp: NULL return value not pointer
authorSimon Wilkinson <sxw@your-file-system.com>
Tue, 26 Feb 2013 11:52:01 +0000 (11:52 +0000)
committerStephan Wiesand <stephan.wiesand@desy.de>
Wed, 28 Aug 2013 12:47:28 +0000 (05:47 -0700)
When afscp_FindCallBack sets its return-by-reference value to NULL,
it should do so to the value itself, not the pointer to it.

Caught by coverity (#988419)

Reviewed-on: http://gerrit.openafs.org/9266
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 99929488511d13dab94491cac1d477062f9da741)

Change-Id: I046189684cef6c88c46455a90ab49d03da1f1cab
Reviewed-on: http://gerrit.openafs.org/9359
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
src/libafscp/afscp_callback.c

index e1f13d7948bd7cfa329233373915e18116e586a5..3bb8062821aa87a31067d3cd2dc3b61634d8c440 100644 (file)
@@ -112,7 +112,7 @@ afscp_FindCallBack(const struct afscp_venusfid *f,
     time_t now;
     struct afscp_venusfid fid;
 
-    ret = NULL;
+    *ret = NULL;
 
     time(&now);
     for (i = 0; i < afscp_maxcallbacks; i++) {