kauth: don't call lcstring with a null source argument

This code was probably never executed, but now that lcstring() has
an AFS_NONNULL annotation, the static analyzer indicates the
potential null-pointer-dereference.

Change-Id: Idb41c2af1cb38bc5c084d4912614e0a553d4aa5a
Reviewed-on: http://gerrit.openafs.org/7864
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>

diff --git a/src/kauth/authclient.c b/src/kauth/authclient.c
index c3d400ca40beef149b1ce59bcfe182bb3c0e034a..10bef97e2436a21c03701bd4f04b088d65150d5f 100644 (file)
--- a/src/kauth/authclient.c
+++ b/src/kauth/authclient.c
@@ -104,8 +104,8 @@ ka_GetServers(char *cell, struct afsconf_cell * cellinfo)
     char cellname[MAXKTCREALMLEN];
 
     LOCK_GLOBAL_MUTEX;
-    if (cell && !strlen(cell))
-       cell = 0;
+    if (cell == NULL || strlen(cell) == 0)
+       cell = NULL;
     else
        cell = lcstring(cellname, cell, sizeof(cellname));