ihandle: Make _ONCLOSE the sync behavior default

The _DELAYED behavior has had serious problems in the past, so change
the default to be _ONCLOSE instead.

This is a 1.6-only change. On master, the _DELAYED option does not
exist at all, and the _ONCLOSE behavior was made the default when this
option was introduced in master, in commit
eb5190eb4a7cd95166866a89e0a8f3a69bbc6e8f.

Change-Id: I01a50e1d829c141c38fbbbaba2c6d2d5a371b130
Reviewed-on: http://gerrit.openafs.org/10809
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: D Brashear <shadow@your-file-system.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

diff --git a/doc/man-pages/pod8/fragments/fileserver-options.pod b/doc/man-pages/pod8/fragments/fileserver-options.pod
index 89cad7da02c1b17c546b73836d4a9d6b5b6a8b56..813e825cd2045c6a1e80bf2233688ec4ed6f888a 100644 (file)
--- a/doc/man-pages/pod8/fragments/fileserver-options.pod
+++ b/doc/man-pages/pod8/fragments/fileserver-options.pod
@@ -316,7 +316,7 @@ or may not be acceptable. This option dictates specifically what the fileserver
 does when it wants to perform a "sync".
 
 There are several options; pass one of these as the argument to -sync. The
-default is C<delayed>.
+default is C<onclose>.
 
 =over 4
 
@@ -356,13 +356,12 @@ the same behavior as with the C<onclose> option.
 
 This option is currently not recommended, since in the past the code
 implementing this option has caused rare data corruption during normal
-operation. However, it is currently the default option to allow consistent
-behavior from previous OpenAFS releases.
+operation.
 
 This was the only behavior allowed in OpenAFS releases starting from 1.4.5 up
-to and including 1.6.2. It is the default starting in OpenAFS 1.6.3. This
-option will be removed in a future version of OpenAFS, and the default behavior
-will likely change to the C<onclose> behavior.
+to and including 1.6.2. It was the default starting from OpenAFS 1.6.3 up to
+and including OpenAFS 1.6.6. This option will be removed in a future version of
+OpenAFS.
 
 =item onclose
 
@@ -378,6 +377,8 @@ Effectively this option is the same as C<never> while a volume is attached and
 actively being used, but if a volume is detached, there is an additional
 guarantee for the data's consistency.
 
+This option is the default starting with OpenAFS 1.6.7.
+
 =item never
 
 This causes all syncs to never do anything. This is the fastest option, with

diff --git a/src/vol/ihandle.c b/src/vol/ihandle.c
index 01426e050de245cbb26edd2b7c3e62064773783c..f1e0ae4fce943dae8932a8c2981fe94e0c3755b2 100644 (file)
--- a/src/vol/ihandle.c
+++ b/src/vol/ihandle.c
@@ -115,7 +115,7 @@ void ih_PkgDefaults(void)
      * is called */
     vol_io_params.fd_max_cachesize = FD_MAX_CACHESIZE;
 
-    vol_io_params.sync_behavior = IH_SYNC_DELAYED;
+    vol_io_params.sync_behavior = IH_SYNC_ONCLOSE;
 }
 
 int