]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
bos: don't dereference a null pointer when printing an error message
authorGarrett Wollman <wollman@csail.mit.edu>
Tue, 9 Aug 2011 03:26:38 +0000 (23:26 -0400)
committerDerrick Brashear <shadow@dementia.org>
Fri, 12 Aug 2011 15:50:59 +0000 (08:50 -0700)
The parameter we are interested in is at MRAFS_OFFSET + 17, not
MRAFS_OFFSET + 13.

Found-by: clang static analyzer
Reviewed-on: http://gerrit.openafs.org/5178
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit bf4b2fd3e26dcf2a0db704815e05d77a558d38c6)

Change-Id: I92db9e5ec10054cef4421ab1b2fd0f60baaf07ca
Reviewed-on: http://gerrit.openafs.org/5222
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/bozo/bos.c

index 57e1a66b02c1601b076199e09b040c6b7f303f13..852e7ac71255ba0140b934d69864fb55b07c273c 100644 (file)
@@ -1583,7 +1583,7 @@ SalvageCmd(struct cmd_syndesc *as, void *arock)
                               &mrafsParm.OptResidencies);
            if (code) {
                printf("bos: '%s' is not a valid residency mask.\n",
-                      as->parms[MRAFS_OFFSET + 13].items->data);
+                      as->parms[MRAFS_OFFSET + 17].items->data);
                return code;
            }
        }