volinfo: fix false good magic line

Fix false report of good magic/version numbers in volume
header file.

Change-Id: I26869b6e6ada331373d626e501f6520755d5c070
Reviewed-on: http://gerrit.openafs.org/4817
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

diff --git a/src/vol/vol-info.c b/src/vol/vol-info.c
index f0f3124b4415d5f3700f5354fc3eaa924f805642..533a9f2bd8b90f2a43da4902fdb1087839551cc9 100644 (file)
--- a/src/vol/vol-info.c
+++ b/src/vol/vol-info.c
@@ -300,11 +300,10 @@ ReadHdr1(IHandle_t * ih, char *to, int size, u_int magic, u_int version)
                    "%s: Write failed for inode %s; header left in damaged state\n",
                    progname, PrintInode(NULL, ih->ih_ino));
        }
-    } else {
-       if (DumpInfo) {
-           printf("Inode %s: Good magic %x and version %x\n",
-                  PrintInode(NULL, ih->ih_ino), magic, version);
-       }
+    }
+    if (!bad && DumpInfo) {
+       printf("Inode %s: Good magic %x and version %x\n",
+              PrintInode(NULL, ih->ih_ino), magic, version);
     }
     return 0;
 }