]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
vos: convertROtoRW incorrect warning when RO not in VLDB
authorMark Vitale <mvitale@sinenomine.net>
Tue, 4 Sep 2012 13:06:44 +0000 (09:06 -0400)
committerDerrick Brashear <shadow@your-file-system.com>
Sun, 7 Oct 2012 13:00:41 +0000 (06:00 -0700)
vos convertROtoRW will issue an incorrect warning about a partition
mismatch if the RO to convert is not in the VLDB.  Only check the
partition if the RO is in the VLDB.

Change-Id: Ib2726bc5bf6697898ad26dc1d817143da3286ba3
Reviewed-on: http://gerrit.openafs.org/8036
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit b650106e301ecefe2f5c8f4a34081af1f5f74901)
Reviewed-on: http://gerrit.openafs.org/8215
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
src/volser/vos.c

index 25ac3e982d882f8cee37434d6c415914d1ef8647..8b5dfd9ca56dc84779b53b914924d0d106f97954 100644 (file)
@@ -5597,7 +5597,7 @@ ConvertRO(struct cmd_syndesc *as, void *arock)
     if (!roserver) {
        fprintf(STDERR, "Warning: RO volume didn't exist in vldb!\n");
     }
-    if (ropartition != partition) {
+    if (roserver && (ropartition != partition)) {
        fprintf(STDERR,
                "Warning: RO volume should be in partition %d instead of %d (vldb)\n",
                ropartition, partition);